Skip to content

fix(ApplicationCommandPermissionsManager): truly optional arg #11165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
+14 −1
Draft

fix(ApplicationCommandPermissionsManager): truly optional arg #11165

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion packages/discord.js/typings/index.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4227,7 +4227,9 @@ export class ApplicationCommandPermissionsManager<
},
): Promise<boolean>;
public fetch(options: FetchSingleOptions): Promise<ApplicationCommandPermissions[]>;
public fetch(options: BaseOptions): Promise<Collection<Snowflake, ApplicationCommandPermissions[]>>;
public fetch(
...args: {} extends BaseOptions ? [] | [BaseOptions] : [BaseOptions]
): Promise<Collection<Snowflake, ApplicationCommandPermissions[]>>;
public remove(
options:
| (FetchSingleOptions & {
Expand Down
11 changes: 11 additions & 0 deletions packages/discord.js/typings/index.test-d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,6 +201,7 @@ import type {
VoiceChannel,
Invite,
GuildInvite,
ApplicationCommandPermissions,
} from './index.js';
import {
ActionRowBuilder,
Expand Down Expand Up @@ -1726,6 +1727,16 @@ declare const guildApplicationCommandManager: GuildApplicationCommandManager;
expectType<Promise<ApplicationCommand>>(guildApplicationCommandManager.fetch('0'));
expectType<Promise<ApplicationCommand>>(guildApplicationCommandManager.fetch({ id: '0' }));
expectType<Promise<Collection<Snowflake, ApplicationCommand>>>(guildApplicationCommandManager.fetch());
expectType<Promise<ApplicationCommandPermissions[]>>(
guildApplicationCommandManager.permissions.fetch({ command: '0' }),
);
expectType<Promise<Collection<Snowflake, ApplicationCommandPermissions[]>>>(
guildApplicationCommandManager.permissions.fetch({}),
);
// https://github.com/discordjs/discord.js/issues/8096
expectType<Promise<Collection<Snowflake, ApplicationCommandPermissions[]>>>(
guildApplicationCommandManager.permissions.fetch(),
);

declare const categoryChannelChildManager: CategoryChannelChildManager;
{
Expand Down