fix: typing mismatch for empty strings being treated as undefined #11287
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
WhatCats
force-pushed
the
fix/typing-mismatch
branch
from
16f28a2 to
847f9d3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
At the moment methods like
GuildMemberManager:fetchthat have an optional string parameter are doing a falsy check for if the parameter was omitted. But consider the following typescript code:According to the typings
membershould be aGuildMemberbut its actually aCollection<Snowflake, GuildMember>because the empty string is falsy (this is why we love JS).My Suggestion
Do more exact undefined/null checks.
(I might not have found every place this is an issue)