Skip to content

Conversation

@Jiralite
Copy link
Member

@Jiralite Jiralite commented Nov 25, 2025

Before the monorepo, discord.js was only the discord.js package. The pull request template made sense (test your API changes, shout if your changes are breaking, and more).

Now, it contains packages like @discordjs/brokers, @discordjs/actions, the api-extractor packages, as well as the website and guide applications. Semantic versioning doesn't really apply to these, and testing API changes certainly doesn't apply for the websites.

I'm moving towards removing the file. At the very least, the status and versioning classification should be removed as we double-check that anyway (it duplicates work). This results in only describing changes, which is common sense.

Open to ideas to generalise this, but I don't think that's possible unlike issue forms.

@vercel
Copy link

vercel bot commented Nov 25, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

2 Skipped Deployments
Project Deployment Preview Comments Updated (UTC)
discord-js Ignored Ignored Nov 25, 2025 7:00am
discord-js-guide Ignored Ignored Nov 25, 2025 7:00am

@Jiralite Jiralite added the chore label Nov 25, 2025
Copy link
Member

@vladfrangu vladfrangu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like we could've kept at least the first header but I know even we struggle to write proper content in there 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: Todo

Development

Successfully merging this pull request may close these issues.

6 participants