refactor(builders)!: use full predicates and disable nested validation #11312
+65
−14
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
Nested validation in chat input commands caused redundant validation passes. Parent predicates only validated structure (type fields), requiring children to validate their own properties.
Changes
Predicates now validate complete nested structures:
fullBasicOptionPredicatevalidating all option properties (name, description, choices, autocomplete, min/max values, channel types)fullSubcommandPredicatevalidating subcommands with nested optionsfullSubcommandGroupPredicatevalidating subcommand groups with nested subcommandschatInputCommandPredicate,chatInputCommandSubcommandPredicate, andchatInputCommandSubcommandGroupPredicateto use full predicatesParent
toJSON()methods now passfalseto children:ChatInputCommandBuilder.toJSON()passesfalseto nested options (line 33)ChatInputCommandSubcommandGroupBuilder.toJSON()passesfalseto subcommands (line 77)ChatInputCommandSubcommandBuilder.toJSON()passesfalseto options (line 110)Result
Each structure validates once at parent level. Top-level
validationOverrideparameter still controls validation behavior—only internal nesting is affected.Status and versioning classification:
Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
downloads.rclone.org/usr/local/bin/node node bin/rclone.js selfupdate(dns block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.