Skip to content

fix: sendSoundboardSound return type#11452

Open
almeidx wants to merge 1 commit intomainfrom
fix/core-send-soundboard-sound-return
Open

fix: sendSoundboardSound return type#11452
almeidx wants to merge 1 commit intomainfrom
fix/core-send-soundboard-sound-return

Conversation

@almeidx
Copy link
Member

@almeidx almeidx commented Mar 18, 2026

@vercel
Copy link

vercel bot commented Mar 18, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

2 Skipped Deployments
Project Deployment Actions Updated (UTC)
discord-js Skipped Skipped Mar 18, 2026 2:27pm
discord-js-guide Skipped Skipped Mar 18, 2026 2:27pm

Request Review

@codecov
Copy link

codecov bot commented Mar 18, 2026

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 31.61%. Comparing base (2a06721) to head (82d9342).

Files with missing lines Patch % Lines
packages/core/src/api/channel.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #11452   +/-   ##
=======================================
  Coverage   31.61%   31.61%           
=======================================
  Files         388      388           
  Lines       14004    14004           
  Branches     1105     1105           
=======================================
  Hits         4427     4427           
  Misses       9440     9440           
  Partials      137      137           
Flag Coverage Δ
brokers 11.56% <ø> (ø)
core 0.00% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@coderabbitai
Copy link

coderabbitai bot commented Mar 18, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 8904270f-d996-4e77-935e-7de0848d9616

📥 Commits

Reviewing files that changed from the base of the PR and between 2a06721 and 82d9342.

📒 Files selected for processing (1)
  • packages/core/src/api/channel.ts
📜 Recent review details
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
  • GitHub Check: Tests
  • GitHub Check: Tests
🔇 Additional comments (1)
packages/core/src/api/channel.ts (1)

699-709: Return behavior is correctly aligned with Promise<void>.

Line 704 now awaits the POST request and does not return a payload, which is consistent with the intended sendSoundboardSound contract change.


📝 Walkthrough

Walkthrough

The sendSoundboardSound method in the ChannelsAPI class was refactored to return Promise<void> instead of Promise<RESTPostAPISendSoundboardSoundResult>. The corresponding type import was removed from public exports, and the implementation was changed from returning the REST call result to awaiting it.

Changes

Cohort / File(s) Summary
Soundboard Send API Update
packages/core/src/api/channel.ts
Removed RESTPostAPISendSoundboardSoundResult type import and refactored sendSoundboardSound method to return Promise<void> instead of a typed Promise, changing implementation from return to await pattern.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately summarizes the main change: fixing the return type of the sendSoundboardSound method from a typed Promise to Promise.
Description check ✅ Passed The description references a related upstream change in discord-api-types, which contextualizes the PR's purpose even though minimal detail is provided.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/core-send-soundboard-sound-return
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Tip

CodeRabbit can use oxc to improve the quality of JavaScript and TypeScript code reviews.

Add a configuration file to your project to customize how CodeRabbit runs oxc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Todo

Development

Successfully merging this pull request may close these issues.

2 participants