Skip to content

Conversation

didinele
Copy link
Member

@didinele didinele commented May 7, 2023

Please describe the changes this PR makes and why it should be merged:
new package pog

🤖 Generated by Copilot at 73ba97a

Sing, O Muse, of the mighty pull request
That brought forth the redis-gateway package
A wondrous work of the @discordjs team
Skilled in the arts of code and docker images

few notes:

  • I used this PR to document core's new Gateway
  • I've updated my name in the other licenses to my legal name due to personal reasons
  • I am yet to test this, so while I am open to reviews and feedback, it is not ready to be merged.

@didinele didinele requested review from a team and iCrawl as code owners May 7, 2023 18:50
@vercel
Copy link

vercel bot commented May 7, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
discord-js ⬜️ Ignored (Inspect) May 8, 2023 2:06pm
discord-js-guide ⬜️ Ignored (Inspect) May 8, 2023 2:06pm

@didinele didinele force-pushed the feat/discord-redis-gateway branch from dbdd44d to 73ba97a Compare May 8, 2023 09:17
@codecov
Copy link

codecov bot commented May 8, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.65%. Comparing base (fa746b0) to head (d2c7c90).
Report is 930 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9541      +/-   ##
==========================================
+ Coverage   58.64%   58.65%   +0.01%     
==========================================
  Files         226      226              
  Lines       14790    14786       -4     
  Branches     1132     1132              
==========================================
  Hits         8673     8673              
+ Misses       6077     6073       -4     
  Partials       40       40              
Flag Coverage Δ
brokers 63.16% <ø> (ø)
builders 98.69% <ø> (ø)
collection 99.88% <ø> (ø)
guide 0.00% <ø> (ø)
proxy 76.31% <ø> (ø)
rest 93.18% <ø> (ø)
util 98.49% <ø> (∅)
utilities 100.00% <ø> (∅)
voice 63.47% <ø> (ø)
website 0.00% <ø> (ø)
ws 54.30% <ø> (∅)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@didinele didinele force-pushed the feat/discord-redis-gateway branch from 73ba97a to 66497f1 Compare May 8, 2023 09:36
@Jiralite Jiralite requested a review from Copilot March 26, 2025 18:17
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces a Redis-based gateway package to handle Discord events using a Redis broker. Additionally, it updates Docker publish workflows, module exports, and label configurations to integrate and support the new package.

  • Introduces the RedisGateway implementation for sending and receiving gateway events via Redis.
  • Updates Docker workflows and label configurations to include the new @discordjs/redis-gateway package.
  • Refactors module exports in core and client files to integrate the new gateway functionality.

Reviewed Changes

Copilot reviewed 23 out of 32 changed files in this pull request and generated no comments.

Show a summary per file
File Description
packages/core/src/gateway/RedisGateway.ts Adds the RedisGateway implementation using a Redis broker for handling gateway events.
packages/redis-gateway/.lintstagedrc.cjs Configures lint-staged for the new redis-gateway package.
.github/workflows/publish-dev-docker.yml Adds a matrix strategy to publish Docker images for redis-gateway and proxy-container packages.
.github/workflows/publish-docker.yml Enhances Docker publish workflow by including the redis-gateway package in the build matrix.
packages/core/src/index.ts Updates module exports to include the new Gateway and RedisGateway modules.
.github/labeler.yml, .github/labels.yml, .github/issue-labeler.yml Adds label configurations for the redis-gateway package.
packages/core/src/gateway/Gateway.ts Adds documentation for the Gateway interface to support both core and Redis-based gateways.
packages/core/src/client.ts Refactors client event mappings and TypeScript types, removing legacy event definitions.
packages/proxy-container/README.md Removes a redundant documentation link in the proxy container README.
Files not reviewed (9)
  • .github/CODEOWNERS: Language not supported
  • packages/brokers/LICENSE: Language not supported
  • packages/core/package.json: Language not supported
  • packages/proxy-container/LICENSE: Language not supported
  • packages/proxy-container/tsconfig.json: Language not supported
  • packages/proxy/LICENSE: Language not supported
  • packages/redis-gateway/.eslintrc.json: Language not supported
  • packages/redis-gateway/.gitignore: Language not supported
  • packages/redis-gateway/.prettierignore: Language not supported

@Jiralite Jiralite marked this pull request as draft July 13, 2025 17:12
@didinele
Copy link
Member Author

Being superseded by #11005

@didinele didinele closed this Jul 18, 2025
@github-project-automation github-project-automation bot moved this from Review in Progress to Denied in discord.js Jul 18, 2025
@didinele didinele deleted the feat/discord-redis-gateway branch July 20, 2025 17:08
@almeidx almeidx removed the blocked label Aug 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

5 participants