fix: use array delete operator to delete array, this was causing a crash in node 24#206
Open
ramesh-kv-rc wants to merge 1 commit intodiscordjs:mainfrom
Open
fix: use array delete operator to delete array, this was causing a crash in node 24#206ramesh-kv-rc wants to merge 1 commit intodiscordjs:mainfrom
ramesh-kv-rc wants to merge 1 commit intodiscordjs:mainfrom
Conversation
Jiralite
approved these changes
Apr 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Testing this node add-on in node 24 Debian bookworm.
This node-addon is causing a SIGSEGV
Steps:
Create multiple (~10-15) OpusEncoders.
Call .decode on them
Release the encoders so that they are deleted.
The next OpusEncoder.decode causes a SIGSEGV.
Fix:
this->outPcm is allocated as an array, but delete was called without the array operator. Adding the array operator fixed the crash.