DEV: Add duplicate tools validation for AiPersona

Author: nvh0412

app/models/ai_persona.rb

@@ -21,6 +21,9 @@ class AiPersona < ActiveRecord::Base
   validates :rag_chunk_overlap_tokens, numericality: { greater_than: -1, maximum: 200 }
   validates :rag_conversation_chunks, numericality: { greater_than: 0, maximum: 1000 }
   validates :forced_tool_count, numericality: { greater_than: -2, maximum: 100_000 }
+
+  validate :tools_can_not_be_duplicated
+
   has_many :rag_document_fragments, dependent: :destroy, as: :target
 
   belongs_to :created_by, class_name: "User"
@@ -106,6 +109,22 @@ def bump_cache
     self.class.persona_cache.flush!
   end
 
+  def tools_can_not_be_duplicated
+    return unless tools.is_a?(Array)
+
+    seen_tools = Set.new
+
+    tools.each do |tool|
+      inner_name, _, _ = tool.is_a?(Array) ? tool : [tool, nil]
+
+      if seen_tools.include?(inner_name)
+        errors.add(:tools, I18n.t("discourse_ai.ai_bot.personas.cannot_have_duplicate_tools"))
+      else
+        seen_tools.add(inner_name)
+      end
+    end
+  end
+
   def class_instance
     attributes = %i[
       id

config/locales/server.en.yml

@@ -174,6 +174,7 @@ en:
         default_llm_required: "Default LLM model is required prior to enabling Chat"
         cannot_delete_system_persona: "System personas cannot be deleted, please disable it instead"
         cannot_edit_system_persona: "System personas can only be renamed, you may not edit tools or system prompt, instead disable and make a copy"
+        cannot_have_duplicate_tools: "Can not have duplicate tools"
         github_helper:
           name: "GitHub Helper"
           description: "AI Bot specialized in assisting with GitHub-related tasks and questions"

lib/ai_bot/personas/general.rb

@@ -10,7 +10,6 @@ def tools
             Tools::Google,
             Tools::Image,
             Tools::Read,
-            Tools::Image,
             Tools::ListCategories,
             Tools::ListTags,
           ]

spec/models/ai_persona_spec.rb

@@ -24,6 +24,29 @@
     expect(persona.valid?).to eq(true)
   end
 
+  it "validates tools" do
+    persona =
+      AiPersona.new(
+        name: "test",
+        description: "test",
+        system_prompt: "test",
+        tools: [],
+        allowed_group_ids: [],
+      )
+
+    expect(persona.valid?).to eq(true)
+
+    persona.tools = [["test-1", { test: "test" }, false]]
+    expect(persona.valid?).to eq(true)
+
+    persona.tools = [["test-1", { test: "test" }, false], ["test-1", { test: "test" }, false]]
+    expect(persona.valid?).to eq(false)
+    expect(persona.errors[:tools]).to eq(["Can not have duplicate tools"])
+
+    persona.tools = [["test-1", { test: "test" }, false], ["test-2", { test: "test" }, false]]
+    expect(persona.valid?).to eq(true)
+  end
+
   it "allows creation of user" do
     persona =
       AiPersona.create!(