DEV: remove redundant check_name implementation for the tool_name field

Author: nvh0412

app/controllers/discourse_ai/admin/ai_tools_controller.rb

@@ -45,12 +45,6 @@ def destroy
         end
       end
 
-      def check_name
-        tool_name = params.require(:tool_name)
-
-        render json: DiscourseAi::ToolNameChecker.new(tool_name).check
-      end
-
       def test
         if params[:id].present?
           ai_tool = AiTool.find(params[:id])

app/services/discourse_ai/tool_name_checker.rb

@@ -1,5 +1,4 @@
 import { TrackedArray, TrackedObject } from "@ember-compat/tracked-built-ins";
-import { ajax } from "discourse/lib/ajax";
 import RestModel from "discourse/models/rest";
 
 const CREATE_ATTRIBUTES = [
@@ -17,11 +16,6 @@ const CREATE_ATTRIBUTES = [
 ];
 
 export default class AiTool extends RestModel {
-  static checkName(name) {
-    return ajax("/admin/plugins/discourse-ai/ai-tools/check-name", {
-      data: { tool_name: name },
-    });
-  }
   createProperties() {
     return this.getProperties(CREATE_ATTRIBUTES);
   }

assets/javascripts/discourse/admin/models/ai-tool.js

@@ -6,18 +6,14 @@ import { action } from "@ember/object";
 import didInsert from "@ember/render-modifiers/modifiers/did-insert";
 import didUpdate from "@ember/render-modifiers/modifiers/did-update";
 import { service } from "@ember/service";
-import { isEmpty } from "@ember/utils";
 import AceEditor from "discourse/components/ace-editor";
 import BackButton from "discourse/components/back-button";
 import DButton from "discourse/components/d-button";
 import DTooltip from "discourse/components/d-tooltip";
-import InputTip from "discourse/components/input-tip";
 import withEventValue from "discourse/helpers/with-event-value";
 import { popupAjaxError } from "discourse/lib/ajax-error";
-import discourseDebounce from "discourse-common/lib/debounce";
 import I18n from "discourse-i18n";
 import ComboBox from "select-kit/components/combo-box";
-import AiTool from "../admin/models/ai-tool";
 import AiToolParameterEditor from "./ai-tool-parameter-editor";
 import AiToolTestModal from "./modal/ai-tool-test-modal";
 import RagOptions from "./rag-options";
@@ -34,15 +30,11 @@ export default class AiToolEditor extends Component {
   @service store;
   @service siteSettings;
 
-  @tracked toolName = null;
   @tracked isSaving = false;
   @tracked editingModel = null;
   @tracked showDelete = false;
   @tracked selectedPreset = null;
 
-  @tracked disableSave = null;
-  @tracked nameValidation = null;
-
   get presets() {
     return this.args.presets.map((preset) => {
       return {
@@ -60,7 +52,6 @@ export default class AiToolEditor extends Component {
   updateModel() {
     this.editingModel = this.args.model.workingCopy();
     this.showDelete = !this.args.model.isNew;
-    this.toolName = this.editingModel.tool_name;
   }
 
   @action
@@ -69,7 +60,6 @@ export default class AiToolEditor extends Component {
     this.editingModel = this.store
       .createRecord("ai-tool", this.selectedPreset)
       .workingCopy();
-
     this.showDelete = false;
   }
 
@@ -86,34 +76,6 @@ export default class AiToolEditor extends Component {
     }
   }
 
-  @action
-  validateAndUpdateToolName(value) {
-    // Skip validation if name hasn't changed
-    if (value === this.jobName) {
-      this._failedInputValidation("");
-      this.disableSave = false;
-      return;
-    }
-
-    this.editingModel.tool_name = value;
-
-    if (value === undefined) {
-      return this._failedInputValidation();
-    }
-
-    if (isEmpty(value)) {
-      return this._failedInputValidation(
-        I18n.t("discourse_ai.tools.new.tool_name.blank")
-      );
-    }
-
-    this._checkToolNameDebounced();
-
-    return this._failedInputValidation(
-      I18n.t("discourse_ai.tools.new.tool_name.checking")
-    );
-  }
-
   _checkToolNameDebounced() {
     discourseDebounce(this, this._checkToolName, 500);
   }
@@ -200,20 +162,6 @@ export default class AiToolEditor extends Component {
     });
   }
 
-  get disableSaveButton() {
-    return this.disableSave || this.isSaving;
-  }
-
-  _failedInputValidation(reason) {
-    this.disableSave = true;
-    const options = { failed: true };
-    if (reason) {
-      options.reason = reason;
-    }
-    this.nameValidation = options;
-    return options;
-  }
-
   <template>
     <BackButton
       @route="adminPlugins.show.discourse-ai-tools"
@@ -260,7 +208,10 @@ export default class AiToolEditor extends Component {
         <div class="control-group">
           <label>{{I18n.t "discourse_ai.tools.tool_name"}}</label>
           <input
-            {{on "input" (withEventValue this.validateAndUpdateToolName)}}
+            {{on
+              "input"
+              (withEventValue (fn (mut this.editingModel.tool_name)))
+            }}
             value={{this.editingModel.tool_name}}
             type="text"
             class="ai-tool-editor__tool_name"
@@ -269,7 +220,6 @@ export default class AiToolEditor extends Component {
             @icon="question-circle"
             @content={{I18n.t "discourse_ai.tools.tool_name_help"}}
           />
-          <InputTip @validation={{this.nameValidation}} />
         </div>
 
         <div class="control-group">
@@ -335,7 +285,7 @@ export default class AiToolEditor extends Component {
           <DButton
             @action={{this.save}}
             @label="discourse_ai.tools.save"
-            @disabled={{this.disableSaveButton}}
+            @disabled={{this.isSaving}}
             class="btn-primary ai-tool-editor__save"
           />
 

assets/javascripts/discourse/components/ai-tool-editor.gjs

@@ -22,7 +22,7 @@ export default class AiToolListEditor extends Component {
           class="btn btn-small btn-primary ai-tool-list-editor__new-button"
         >
           {{icon "plus"}}
-          <span>{{I18n.t "discourse_ai.tools.new.title"}}</span>
+          <span>{{I18n.t "discourse_ai.tools.new"}}</span>
         </LinkTo>
       </div>
 

assets/javascripts/discourse/components/ai-tool-list-editor.gjs

@@ -211,6 +211,7 @@ en:
       tools:
         back: "Back"
         short_title: "Tools"
+        new: "New tool"
         name: "Name"
         name_help: "Name will show up in the Discourse UI and is the short identifier you will use to find the tool in various settings, it should be distinct (it is required)"
         tool_name: "Tool Name"
@@ -241,12 +242,6 @@ en:
           title: "Test AI Tool"
           run: "Run Test"
           result: "Test Result"
-        new:
-          title: "New Tool"
-          tool_name:
-            blank: "Tool name cannot be blank"
-            checking: "Checking tool name…"
-            available: "Tool name is available"
 
       llms:
         short_title: "LLMs"

config/locales/client.en.yml

@@ -51,12 +51,7 @@
       only: %i[index create show update destroy],
       path: "ai-tools",
       controller: "discourse_ai/admin/ai_tools",
-    ) do
-      collection do
-        post :test
-        get "check-name" => "discourse_ai/admin/ai_tools#check_name"
-      end
-    end
+    ) { post :test, on: :collection }
 
     post "/ai-personas/:id/create-user", to: "discourse_ai/admin/ai_personas#create_user"