DEV: Embeddings, tools, personas

Author: keegangeorge

app/controllers/discourse_ai/admin/ai_embeddings_controller.rb

@@ -40,6 +40,7 @@ def create
         embedding_def = EmbeddingDefinition.new(ai_embeddings_params)
 
         if embedding_def.save
+          log_ai_embedding_creation(embedding_def)
           render json: AiEmbeddingDefinitionSerializer.new(embedding_def), status: :created
         else
           render_json_error embedding_def
@@ -55,7 +56,11 @@ def update
           )
         end
 
+        # Capture initial state for logging
+        initial_attributes = embedding_def.attributes.dup
+        
         if embedding_def.update(ai_embeddings_params.except(:dimensions))
+          log_ai_embedding_update(embedding_def, initial_attributes)
           render json: AiEmbeddingDefinitionSerializer.new(embedding_def)
         else
           render_json_error embedding_def
@@ -75,7 +80,16 @@ def destroy
           return render_json_error(I18n.t("discourse_ai.embeddings.delete_failed"), status: 409)
         end
 
+        # Capture embedding details for logging before destruction
+        embedding_details = {
+          embedding_id: embedding_def.id,
+          display_name: embedding_def.display_name,
+          provider: embedding_def.provider,
+          dimensions: embedding_def.dimensions
+        }
+        
         if embedding_def.destroy
+          log_ai_embedding_deletion(embedding_details)
           head :no_content
         else
           render_json_error embedding_def
@@ -128,6 +142,75 @@ def ai_embeddings_params
 
         permitted
       end
+      
+      def log_ai_embedding_creation(embedding_def)
+        # Create log details
+        log_details = {
+          embedding_id: embedding_def.id,
+          display_name: embedding_def.display_name,
+          provider: embedding_def.provider,
+          dimensions: embedding_def.dimensions
+        }
+        
+        # Only include tokenizer if present
+        if embedding_def.tokenizer_class.present?
+          log_details[:tokenizer] = embedding_def.tokenizer_class
+        end
+        
+        # For sensitive fields, don't include the actual content
+        if embedding_def.api_key.present?
+          log_details[:api_key_set] = true
+        end
+        
+        # Log the action
+        StaffActionLogger.new(current_user).log_custom("create_ai_embedding", log_details)
+      end
+      
+      def log_ai_embedding_update(embedding_def, initial_attributes)
+        # Create log details
+        log_details = {
+          embedding_id: embedding_def.id,
+          display_name: embedding_def.display_name
+        }
+        
+        # Track changes in fields
+        changed_fields = []
+        
+        # Fields to check for changes
+        %w[display_name provider url tokenizer_class max_sequence_length embed_prompt search_prompt matryoshka_dimensions].each do |field|
+          if initial_attributes[field] != embedding_def.attributes[field]
+            changed_fields << field
+            log_details["#{field}_changed"] = true
+          end
+        end
+        
+        # Special handling for API key (sensitive)
+        if initial_attributes['api_key'].present? != embedding_def.api_key.present?
+          changed_fields << 'api_key'
+          
+          if embedding_def.api_key.present?
+            log_details[:api_key_set] = true
+          else
+            log_details[:api_key_removed] = true
+          end
+        end
+        
+        # Special handling for provider_params (JSON)
+        if initial_attributes['provider_params'].to_s != embedding_def.provider_params.to_s
+          changed_fields << 'provider_params'
+          log_details[:provider_params_changed] = true
+        end
+        
+        # Only log if there are actual changes
+        if changed_fields.any?
+          log_details[:changed_fields] = changed_fields
+          StaffActionLogger.new(current_user).log_custom("update_ai_embedding", log_details)
+        end
+      end
+      
+      def log_ai_embedding_deletion(embedding_details)
+        StaffActionLogger.new(current_user).log_custom("delete_ai_embedding", embedding_details)
+      end
     end
   end
 end

app/controllers/discourse_ai/admin/ai_llms_controller.rb

@@ -207,81 +207,95 @@ def ai_llm_params(updating: nil)
       end
 
       def log_llm_model_creation(llm_model)
-        log_details = {
+        # Create field configuration with appropriate types
+        field_config = {
+          display_name: {},
+          name: {},
+          provider: {},
+          tokenizer: {},
+          url: {},
+          api_key: { type: :sensitive },
+          max_prompt_tokens: {},
+          max_output_tokens: {},
+          enabled_chat_bot: {},
+          vision_enabled: {},
+          input_cost: {},
+          output_cost: {},
+          cached_input_cost: {},
+          provider_params: {}
+        }
+        
+        # Create basic entity details
+        entity_details = {
           model_id: llm_model.id,
-          display_name: llm_model.display_name,
-          name: llm_model.name,
-          provider: llm_model.provider,
-          tokenizer: llm_model.tokenizer,
-          enabled_chat_bot: llm_model.enabled_chat_bot,
-          vision_enabled: llm_model.vision_enabled,
+          model_name: llm_model.name,
+          display_name: llm_model.display_name
         }
-
-        # Add cost details if present
-        if llm_model.input_cost.present?
-          log_details[:input_cost] = llm_model.input_cost
-        end
-        if llm_model.output_cost.present?
-          log_details[:output_cost] = llm_model.output_cost
-        end
-        if llm_model.cached_input_cost.present?
-          log_details[:cached_input_cost] = llm_model.cached_input_cost
-        end
-
-        # Add quota information if present
+        
+        # Create logger instance
+        logger = DiscourseAi::Utils::AiStaffActionLogger.new(current_user)
+        
+        # Extract attributes based on field configuration
+        log_details = entity_details.dup
+        log_details.merge!(logger.send(:extract_entity_attributes, llm_model, field_config))
+        
+        # Add quota information as a special case
         if llm_model.llm_quotas.any?
           log_details[:quotas] = llm_model.llm_quotas.map do |quota|
             "Group #{quota.group_id}: #{quota.max_tokens} tokens, #{quota.max_usages} usages, #{quota.duration_seconds}s"
           end.join("; ")
         end
-
-        logger = DiscourseAi::Utils::AiStaffActionLogger.new(current_user)
+        
         logger.log_custom("create_ai_llm_model", log_details)
       end
 
       def log_llm_model_update(llm_model, initial_attributes, initial_quotas)
-        current_attributes = llm_model.attributes
-        current_quotas = llm_model.llm_quotas.reload.map(&:attributes)
-
-        # Track changes to main attributes
+        # Create field configuration with appropriate types
+        field_config = {
+          display_name: {},
+          name: {},
+          provider: {},
+          tokenizer: {},
+          url: {},
+          api_key: { type: :sensitive },
+          max_prompt_tokens: {},
+          max_output_tokens: {},
+          enabled_chat_bot: {},
+          vision_enabled: {},
+          input_cost: {},
+          output_cost: {},
+          cached_input_cost: {},
+          provider_params: {},
+          json_fields: %w[provider_params]
+        }
+        
+        # Create basic entity details
+        entity_details = {
+          model_id: llm_model.id,
+          model_name: llm_model.name,
+          display_name: llm_model.display_name
+        }
+        
+        # Create logger instance
+        logger = DiscourseAi::Utils::AiStaffActionLogger.new(current_user)
+        
+        # Create a changes hash to track all changes
         changes = {}
-        trackable_fields = %w[
-          display_name name provider tokenizer url max_prompt_tokens max_output_tokens
-          enabled_chat_bot vision_enabled input_cost output_cost cached_input_cost
-          provider_params
-        ]
-
-        trackable_fields.each do |field|
-          initial_value = initial_attributes[field]
-          current_value = current_attributes[field]
-          
-          if initial_value != current_value
-            # Handle API key specially - don't log the actual values for security
-            if field == "api_key"
-              changes[field] = initial_value.present? && current_value.present? ? 
-                "updated" : (current_value.present? ? "set" : "removed")
-            else
-              changes[field] = "#{initial_value} → #{current_value}"
-            end
-          end
-        end
-
-        # Track quota changes
+        current_quotas = llm_model.llm_quotas.reload.map(&:attributes)
+        
+        # Track quota changes separately as they're a special case
         if initial_quotas != current_quotas
           initial_quota_summary = initial_quotas.map { |q| "Group #{q['group_id']}: #{q['max_tokens']} tokens" }.join("; ")
           current_quota_summary = current_quotas.map { |q| "Group #{q['group_id']}: #{q['max_tokens']} tokens" }.join("; ")
           changes[:quotas] = "#{initial_quota_summary} → #{current_quota_summary}"
         end
-
-        # Only log if there are actual changes
-        if changes.any?
-          log_details = {
-            model_id: llm_model.id,
-            model_name: llm_model.display_name || llm_model.name,
-          }.merge(changes)
-
-          logger = DiscourseAi::Utils::AiStaffActionLogger.new(current_user)
-          logger.log_custom("update_ai_llm_model", log_details)
+        
+        # Let the logger handle standard field changes
+        logger.log_update("llm_model", llm_model, initial_attributes, field_config, entity_details)
+        
+        # If we have quota changes but no other changes were detected, log them separately
+        if changes.key?(:quotas)
+          logger.log_custom("update_ai_llm_model", entity_details.merge(changes))
         end
       end
 

app/controllers/discourse_ai/admin/ai_personas_controller.rb

@@ -276,40 +276,93 @@ def permit_examples(examples)
       end
 
       def log_ai_persona_creation(ai_persona)
-        # Extract standard attributes
-        log_details = {
+        # Create field configuration with appropriate types
+        field_config = {
+          name: {},
+          description: {},
+          enabled: {},
+          priority: {},
+          system_prompt: { type: :large_text },
+          default_llm_id: {},
+          temperature: {},
+          top_p: {},
+          user_id: {},
+          vision_enabled: {},
+          vision_max_pixels: {},
+          max_context_posts: {},
+          rag_chunk_tokens: {},
+          rag_chunk_overlap_tokens: {},
+          rag_conversation_chunks: {},
+          rag_llm_model_id: {},
+          question_consolidator_llm_id: {},
+          tool_details: {},
+          forced_tool_count: {},
+          allow_chat_channel_mentions: {},
+          allow_chat_direct_messages: {},
+          allow_topic_mentions: {},
+          allow_personal_messages: {}
+        }
+        
+        # Create basic entity details
+        entity_details = {
           persona_id: ai_persona.id,
-          name: ai_persona.name,
-          description: ai_persona.description,
-          enabled: ai_persona.enabled,
-          priority: ai_persona.priority,
-          system_prompt: ai_persona.system_prompt&.truncate(100),
-          default_llm_id: ai_persona.default_llm_id,
-          temperature: ai_persona.temperature,
-          top_p: ai_persona.top_p,
-          user_id: ai_persona.user_id,
-          vision_enabled: ai_persona.vision_enabled,
-          tools_count: (ai_persona.tools || []).size,
-          allowed_group_ids: ai_persona.allowed_group_ids
+          persona_name: ai_persona.name
         }
 
+        # Create logger instance
         logger = DiscourseAi::Utils::AiStaffActionLogger.new(current_user)
+        
+        # Extract attributes based on field configuration
+        log_details = entity_details.dup
+        log_details.merge!(logger.send(:extract_entity_attributes, ai_persona, field_config))
+        
+        # Add tools count separately as it's not a direct attribute
+        log_details[:tools_count] = (ai_persona.tools || []).size
+        
+        # Add allowed_group_ids
+        log_details[:allowed_group_ids] = ai_persona.allowed_group_ids if ai_persona.allowed_group_ids.present?
+        
         logger.log_custom("create_ai_persona", log_details)
       end
 
       def log_ai_persona_update(ai_persona, initial_attributes)
-        trackable_fields = %w[
-          name description enabled system_prompt priority temperature top_p default_llm_id
-          user_id max_context_posts vision_enabled vision_max_pixels rag_chunk_tokens
-          rag_chunk_overlap_tokens rag_conversation_chunks rag_llm_model_id
-          question_consolidator_llm_id tool_details forced_tool_count
-          allow_chat_channel_mentions allow_chat_direct_messages allow_topic_mentions allow_personal_messages
-        ]
-
-        json_fields = %w[allowed_group_ids tools response_format examples]
+        # Create field configuration with appropriate types
+        field_config = {
+          name: {},
+          description: {},
+          enabled: {},
+          priority: {},
+          system_prompt: { type: :large_text },
+          default_llm_id: {},
+          temperature: {},
+          top_p: {},
+          user_id: {},
+          vision_enabled: {},
+          vision_max_pixels: {},
+          max_context_posts: {},
+          rag_chunk_tokens: {},
+          rag_chunk_overlap_tokens: {},
+          rag_conversation_chunks: {},
+          rag_llm_model_id: {},
+          question_consolidator_llm_id: {},
+          tool_details: {},
+          forced_tool_count: {},
+          allow_chat_channel_mentions: {},
+          allow_chat_direct_messages: {},
+          allow_topic_mentions: {},
+          allow_personal_messages: {},
+          json_fields: %w[allowed_group_ids tools response_format examples]
+        }
+        
+        # Create basic entity details
+        entity_details = {
+          persona_id: ai_persona.id,
+          persona_name: ai_persona.name
+        }
 
+        # Create logger instance and log the update
         logger = DiscourseAi::Utils::AiStaffActionLogger.new(current_user)
-        logger.log_update("persona", ai_persona, initial_attributes, trackable_fields, json_fields)
+        logger.log_update("persona", ai_persona, initial_attributes, field_config, entity_details)
       end
 
       def log_ai_persona_deletion(persona_details)