WIP: Use personas for summarization

Author: romanrizzi

app/models/ai_persona.rb

@@ -46,13 +46,16 @@ def self.persona_cache
 
   scope :ordered, -> { order("priority DESC, lower(name) ASC") }
 
-  def self.all_personas
+  def self.all_personas(only_enabled: true)
     persona_cache[:value] ||= AiPersona
       .ordered
-      .where(enabled: true)
       .all
       .limit(MAX_PERSONAS_PER_SITE)
       .map(&:class_instance)
+
+    return persona_cache[:value] if !only_enabled
+
+    persona_cache[:value].select { |p| p.enabled }
   end
 
   def self.persona_users(user: nil)

config/locales/server.en.yml

@@ -303,6 +303,12 @@ en:
         web_artifact_creator:
           name: "Web Artifact Creator"
           description: "AI Bot specialized in creating interactive web artifacts"
+        summarizer:
+          name: "Summarizer"
+          description: "Default persona used to power AI summaries."
+        short_summarizer:
+          name: "Summarizer (short form)"
+          description: "Default persona used to power AI short summaries for topic lists' items."
       topic_not_found: "Summary unavailable, topic not found!"
       summarizing: "Summarizing topic"
       searching: "Searching for: '%{query}'"

config/settings.yml

@@ -240,18 +240,29 @@ discourse_ai:
     type: enum
     enum: "DiscourseAi::Configuration::LlmEnumerator"
     validator: "DiscourseAi::Configuration::LlmValidator"
+  ai_summarization_persona:
+    default: "-11"
+    type: enum
+    enum: "DiscourseAi::Configuration::PersonaEnumerator"
+
   ai_pm_summarization_allowed_groups:
     type: group_list
     list_type: compact
     default: ""
-  ai_custom_summarization_allowed_groups:
+  ai_custom_summarization_allowed_groups: # Deprecated. TODO(roman): Remove 2025-09-01
     type: group_list
     list_type: compact
     default: "3|13" # 3: @staff, 13: @trust_level_3
+    hidden: true
   ai_summary_gists_enabled:
     default: false
     hidden: true
-  ai_summary_gists_allowed_groups:
+  ai_summary_gists_persona:
+    default: "-12"
+    type: enum
+    enum: "DiscourseAi::Configuration::PersonaEnumerator"
+    hidden: true
+  ai_summary_gists_allowed_groups: # Deprecated. TODO(roman): Remove 2025-09-01
     type: group_list
     list_type: compact
     default: "0" #everyone

db/fixtures/personas/603_ai_personas.rb

@@ -1,17 +1,39 @@
 # frozen_string_literal: true
 
+summarization_personas = [DiscourseAi::Personas::Summarizer, DiscourseAi::Personas::ShortSummarizer]
+
 DiscourseAi::Personas::Persona.system_personas.each do |persona_class, id|
   persona = AiPersona.find_by(id: id)
   if !persona
     persona = AiPersona.new
     persona.id = id
+
     if persona_class == DiscourseAi::Personas::WebArtifactCreator
       # this is somewhat sensitive, so we default it to staff
       persona.allowed_group_ids = [Group::AUTO_GROUPS[:staff]]
+    elsif summarization_personas.include?(persona_class)
+      # Copy group permissions from site settings.
+      default_groups = [Group::AUTO_GROUPS[:staff], Group::AUTO_GROUPS[:trust_level_3]]
+
+      setting_name = "ai_custom_summarization_allowed_groups"
+      if persona_class == DiscourseAi::Personas::ShortSummarizer
+        setting_name = "ai_summary_gists_allowed_groups"
+        default_groups = [] # Blank == everyone
+      end
+
+      persona.allowed_group_ids =
+        DB
+          .query_single(
+            "SELECT value FROM site_settings WHERE name = :setting_name",
+            setting_name: setting_name,
+          )
+          .first
+          &.split("|") || default_groups
     else
       persona.allowed_group_ids = [Group::AUTO_GROUPS[:trust_level_0]]
     end
-    persona.enabled = true
+
+    persona.enabled = !summarization_personas.include?(persona_class)
     persona.priority = true if persona_class == DiscourseAi::Personas::General
   end
 
@@ -22,16 +44,16 @@
     persona_class.name + SecureRandom.hex,
   ]
   persona.name = DB.query_single(<<~SQL, names, id).first
-        SELECT guess_name
-        FROM (
-          SELECT unnest(Array[?]) AS guess_name
-          FROM (SELECT 1) as t
-        ) x
-        LEFT JOIN ai_personas ON ai_personas.name = x.guess_name AND ai_personas.id <> ?
-        WHERE ai_personas.id IS NULL
-        ORDER BY x.guess_name ASC
-        LIMIT 1
-      SQL
+    SELECT guess_name
+    FROM (
+      SELECT unnest(Array[?]) AS guess_name
+      FROM (SELECT 1) as t
+    ) x
+    LEFT JOIN ai_personas ON ai_personas.name = x.guess_name AND ai_personas.id <> ?
+    WHERE ai_personas.id IS NULL
+    ORDER BY x.guess_name ASC
+    LIMIT 1
+  SQL
 
   persona.description = persona_class.description
 

lib/ai_bot/playground.rb

@@ -283,44 +283,6 @@ def title_playground(post, user)
           title: new_title.sub(/\A"/, "").sub(/"\Z/, ""),
         )
 
-        system_insts = <<~TEXT.strip
-          You are titlebot. Given a conversation, you will suggest a title.
-  
-          - You will never respond with anything but the suggested title.
-          - You will always match the conversation language in your title suggestion.
-          - Title will capture the essence of the conversation.
-          TEXT
-
-        instruction = <<~TEXT.strip
-          Given the following conversation:
-  
-          {{{
-          #{conversation}
-          }}}
-  
-          Reply only with a title that is 7 words or less.
-          TEXT
-
-        title_prompt =
-          DiscourseAi::Completions::Prompt.new(
-            system_insts,
-            messages: [type: :user, content: instruction],
-            topic_id: post.topic_id,
-          )
-
-        title =
-          bot
-            .llm
-            .generate(title_prompt, user: user, feature_name: "bot_title")
-            .strip
-            .split("\n")
-            .last
-
-        PostRevisor.new(post.topic.first_post, post.topic).revise!(
-          bot.bot_user,
-          title: title.sub(/\A"/, "").sub(/"\Z/, ""),
-        )
-
         allowed_users = post.topic.topic_allowed_users.pluck(:user_id)
         MessageBus.publish(
           "/discourse-ai/ai-bot/topic/#{post.topic.id}",

lib/configuration/persona_enumerator.rb

@@ -10,7 +10,9 @@ def self.valid_value?(val)
       end
 
       def self.values
-        AiPersona.all_personas.map { |persona| { name: persona.name, value: persona.id } }
+        AiPersona
+          .all_personas(only_enabled: false)
+          .map { |persona| { name: persona.name, value: persona.id } }
       end
     end
   end

lib/guardian_extensions.rb

@@ -24,24 +24,26 @@ def can_see_summary?(target)
     def can_see_gists?
       return false if !SiteSetting.ai_summarization_enabled
       return false if !SiteSetting.ai_summary_gists_enabled
-      if SiteSetting.ai_summary_gists_allowed_groups.to_s == Group::AUTO_GROUPS[:everyone].to_s
-        return true
+
+      if (ai_persona = AiPersona.find_by(id: SiteSetting.ai_summary_gists_persona)).blank?
+        return false
       end
+      persona_groups = ai_persona.allowed_group_ids.to_a
+      return true if persona_groups.empty?
       return false if anonymous?
-      return false if SiteSetting.ai_summary_gists_allowed_groups_map.empty?
 
-      SiteSetting.ai_summary_gists_allowed_groups_map.any? do |group_id|
-        user.group_ids.include?(group_id)
-      end
+      ai_persona.allowed_group_ids.to_a.any? { |group_id| user.group_ids.include?(group_id) }
     end
 
     def can_request_summary?
       return false if anonymous?
 
       user_group_ids = user.group_ids
-      SiteSetting.ai_custom_summarization_allowed_groups_map.any? do |group_id|
-        user_group_ids.include?(group_id)
+      if (ai_persona = AiPersona.find_by(id: SiteSetting.ai_summarization_persona)).blank?
+        return false
       end
+
+      ai_persona.allowed_group_ids.to_a.any? { |group_id| user.group_ids.include?(group_id) }
     end
 
     def can_debug_ai_bot_conversation?(target)

lib/personas/bot.rb

@@ -28,7 +28,7 @@ def initialize(bot_user, persona, model = nil)
       attr_accessor :persona
 
       def llm
-        @llm ||= DiscourseAi::Completions::Llm.proxy(model)
+        DiscourseAi::Completions::Llm.proxy(model)
       end
 
       def force_tool_if_needed(prompt, context)
@@ -51,7 +51,7 @@ def force_tool_if_needed(prompt, context)
         end
       end
 
-      def reply(context, &update_blk)
+      def reply(context, llm_args: {}, &update_blk)
         unless context.is_a?(BotContext)
           raise ArgumentError, "context must be an instance of BotContext"
         end
@@ -67,6 +67,7 @@ def reply(context, &update_blk)
         llm_kwargs = { user: user }
         llm_kwargs[:temperature] = persona.temperature if persona.temperature
         llm_kwargs[:top_p] = persona.top_p if persona.top_p
+        llm_kwargs[:max_tokens] = llm_args[:max_tokens] if llm_args[:max_tokens].present?
 
         needs_newlines = false
         tools_ran = 0
@@ -84,7 +85,7 @@ def reply(context, &update_blk)
           result =
             current_llm.generate(
               prompt,
-              feature_name: "bot",
+              feature_name: context.feature_name,
               partial_tool_calls: allow_partial_tool_calls,
               output_thinking: true,
               **llm_kwargs,
@@ -246,13 +247,8 @@ def process_tool(
         raw_context << [invocation_result_json, tool_call_id, "tool", tool.name]
       end
 
-<<<<<<< HEAD
-      def invoke_tool(tool, llm, cancel, context, &update_blk)
-        show_placeholder = !context.skip_tool_details && !tool.class.allow_partial_tool_calls?
-=======
       def invoke_tool(tool, cancel, context, &update_blk)
-        show_placeholder = !context[:skip_tool_details] && !tool.class.allow_partial_tool_calls?
->>>>>>> 5bfe2314 (REFACTOR: Move personas into it's own module.)
+        show_placeholder = !context.skip_tool_details && !tool.class.allow_partial_tool_calls?
 
         update_blk.call("", cancel, build_placeholder(tool.summary, "")) if show_placeholder
 

lib/personas/bot_context.rb

@@ -14,7 +14,9 @@ class BotContext
                     :chosen_tools,
                     :message_id,
                     :channel_id,
-                    :context_post_ids
+                    :context_post_ids,
+                    :feature_name,
+                    :resource_url
 
       def initialize(
         post: nil,
@@ -29,7 +31,9 @@ def initialize(
         time: nil,
         message_id: nil,
         channel_id: nil,
-        context_post_ids: nil
+        context_post_ids: nil,
+        feature_name: "bot",
+        resource_url: nil
       )
         @participants = participants
         @user = user
@@ -45,6 +49,7 @@ def initialize(
         @site_title = site_title
         @site_description = site_description
         @time = time
+        @feature_name = feature_name
 
         if post
           @post_id = post.id
@@ -56,7 +61,7 @@ def initialize(
       end
 
       # these are strings that can be safely interpolated into templates
-      TEMPLATE_PARAMS = %w[time site_url site_title site_description participants]
+      TEMPLATE_PARAMS = %w[time site_url site_title site_description participants resource_url]
 
       def lookup_template_param(key)
         public_send(key.to_sym) if TEMPLATE_PARAMS.include?(key)
@@ -100,6 +105,8 @@ def to_json
           site_title: @site_title,
           site_description: @site_description,
           skip_tool_details: @skip_tool_details,
+          feature_name: @feature_name,
+          resource_url: @resource_url,
         }
       end
     end

lib/personas/persona.rb

@@ -44,6 +44,8 @@ def system_personas
             DiscourseHelper => -8,
             GithubHelper => -9,
             WebArtifactCreator => -10,
+            Summarizer => -11,
+            ShortSummarizer => -12,
           }
         end