This repository was archived by the owner on Jul 22, 2025. It is now read-only.
DEV: Move semantic search from connector to component #1048
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keegangeorge
approved these changes
Jan 2, 2025
Member
keegangeorge
left a comment
keegangeorge
left a comment
There was a problem hiding this comment.
LGTM! Just some small suggestions for class names
| import AiSemanticSearch from "../../components/ai-semantic-search"; | ||
|
|
||
| export default class SemanticSearch extends Component { | ||
| export default class SemanticSearchConnector extends Component { |
Member
There was a problem hiding this comment.
We're moving away from the name of Semantic Search in favour of AI search (see /t/141433), so maybe can we call this either AiSearchConnector or AiFullPageSearch ?
| import DTooltip from "float-kit/components/d-tooltip"; | ||
| import AiIndicatorWave from "./ai-indicator-wave"; | ||
|
|
||
| export default class AiSemanticSearch extends Component { |
Member
There was a problem hiding this comment.
We're moving away from the name of Semantic Search in favour of AI search (see /t/141433), so maybe can we call this either AiSearch or AiFullPageSearch ?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the ai-semantic-search component into it's own component file, instead of being directly defined in the connector. This allows for re-use elsewhere. (by other themes/plugins)