This repository was archived by the owner on Jul 22, 2025. It is now read-only.
DEV: Add no-results className to full page search toggle #1055
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keegangeorge
approved these changes
Jan 10, 2025
Member
keegangeorge
left a comment
keegangeorge
left a comment
There was a problem hiding this comment.
LGTM! But one small suggestion to improve code a bit while we're updating things here. If you need this sooner though, feel free to merge and follow-up later.
assets/javascripts/discourse/components/ai-full-page-search.gjs
Outdated
Show resolved
Hide resolved
keegangeorge
approved these changes
Jan 10, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed to customize the colors of the toggle for this state :)