This repository was archived by the owner on Jul 22, 2025. It is now read-only.
FIX: add viewport so artifacts render correctly on mobile #1056
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When sharing artifacts on mobile we had no viewport tag so text would be TINY
This is required for models such o1 that do not have streaming enabled yet It is good to carry this feature around in case various apis decide not to support streaming endpoints
nattsw
reviewed
Jan 13, 2025
lib/completions/endpoints/base.rb
Outdated
| end | ||
|
|
||
| def disable_streaming? | ||
| @disable_streaming = llm_model.lookup_custom_param("disable_streaming") |
Contributor
There was a problem hiding this comment.
What will happen for existing llm models? Does this default to a false / blank?
Member
Author
There was a problem hiding this comment.
sure will add a double negative here, good call, no need for migration by default we don't disable so it is just "not disabled"
nattsw
approved these changes
Jan 13, 2025
Contributor
nattsw
left a comment
nattsw
left a comment
There was a problem hiding this comment.
Generally looks ok but I am not sure what the behaviour is now for existing models without the param.
Is a migration needed?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When sharing artifacts on mobile we had no viewport tag so
text would be TINY