Skip to content
This repository was archived by the owner on Jul 22, 2025. It is now read-only.

Conversation

@SamSaffron
Copy link
Member

When enabling spam scanner it there may be old unscanned posts
this can create a risky situation where spam scanner operates
on legit posts during false positives

To keep this a lot safer we no longer try to hide old stuff by
the spammers.

When enabling spam scanner it there may be old unscanned posts
this can create a risky situation where spam scanner operates
on legit posts during false positives

To keep this a lot safer we no longer try to hide old stuff by
the spammers.
Copy link
Contributor

@nattsw nattsw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To keep this a lot safer we no longer try to hide old stuff by the spammers.

Yeah I think this is better. It's an easier action to undo on users if the flag is "denied"

.where("created_at > ?", 24.hours.ago)
.select(:topic_id)
def self.hide_post(post)
Post.where(id: post.id).update_all(
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for very odd edge cases where there is no topic, I have seen that before.

@nattsw
Copy link
Contributor

nattsw commented Jan 15, 2025

Sorry, deleted my comment on the find after I realised the same thing (review queue actions can lead to some weird state).

@SamSaffron SamSaffron merged commit 81b952d into main Jan 15, 2025
6 checks passed
@SamSaffron SamSaffron deleted the smarter-flag-handling branch January 15, 2025 05:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants