DEV: converts llm admin page to use form kit #1099
Conversation
| async testConfig() { | ||
| return await ajax(`/admin/plugins/discourse-ai/ai-llms/test.json`, { | ||
| data: { ai_llm: this.createProperties() }, | ||
| async testConfig(llmConfig) { |
There was a problem hiding this comment.
I allowed to pass an arbitrary llmConfig object to test
| @@ -1,178 +0,0 @@ | |||
| import Component from "@glimmer/component"; | |||
There was a problem hiding this comment.
I just moved all of this in the form, I could split it in multiple components, but there was not much value to it. It's implemented using the collection from form kit: https://meta.discourse.org/t/discourse-toolkit-to-render-forms/326439?silent=true
| import AiLlmEditorForm from "./ai-llm-editor-form"; | ||
|
|
||
| export default class AiLlmEditor extends Component { | ||
| constructor() { |
There was a problem hiding this comment.
moved all of this in the form as it's technically the form data
| grid-template-columns: repeat(auto-fill, minmax(16em, 1fr)); | ||
| gap: 1em 2em; | ||
| margin-top: 1em; | ||
| border-top: 3px solid var(--primary-low); // matches tbody border |
There was a problem hiding this comment.
I had a super weird behavior in my editor with this comment not sure why, removed it for now
| expect(llm.user_id).not_to be_nil | ||
| end | ||
|
|
||
| context "with quotas" do |
There was a problem hiding this comment.
added simple tests for quotas
keegangeorge
left a comment
keegangeorge
left a comment
There was a problem hiding this comment.
LGTM! One small suggestion
| openAddQuotaModal() { | ||
| this.modalIsVisible = true; |
There was a problem hiding this comment.
Is there a particular reason why this is being switched to using the modal service instead of the declarative technique in the template? I believe declarative technique is preferred when possible (ref).
Can we mut a tracked property for addItemToCollection that gets passed as an arg to the modal?
There was a problem hiding this comment.
why would it be preferred here? It's a lot more code to be declarative here, you even have to use your own tracked property.
assets/javascripts/discourse/components/modal/ai-llm-quota-modal.gjs
Outdated
Show resolved
Hide resolved
|
sorry my change just created a merge conflict @jjaffeux |
no worries, im merging today, I had fixes to do in core which I just merged |
This also converts the quota editor, and the quota modal. The most debatable change is that I moved tooltips into descriptions, we can change this in the future if that's a significant issue.
…al.gjs Co-authored-by: Martin Brennan <[email protected]>
jjaffeux
force-pushed
the
llm-config-form-kit
branch
from
3c4b04b to
6f38591
Compare
This also converts the quota editor, and the quota modal.
The most debatable change is that I moved tooltips into descriptions, we can change this in the future if that's a significant issue.