Skip to content
This repository was archived by the owner on Jul 22, 2025. It is now read-only.

WIP: Adding Enum button back to AI tools parameters form #1200

Closed
wants to merge 1 commit into from
Closed

WIP: Adding Enum button back to AI tools parameters form #1200

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions assets/javascripts/discourse/admin/models/ai-tool.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,10 @@ export default class AiTool extends RestModel {

if (parameter.enum && parameter.enum.length) {
parameter.enum = new TrackedArray(parameter.enum);
parameter.isEnum = true;
} else {
parameter.enum = null;
parameter.isEnum = false;
Copy link
Member

@SamSaffron SamSaffron Mar 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need this to be opaque to rest model cause we don't want to send it to the server

}

return parameter;
Expand Down
28 changes: 20 additions & 8 deletions assets/javascripts/discourse/components/ai-tool-editor-form.gjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,12 +28,13 @@ export default class AiToolEditorForm extends Component {
];

get formData() {
const parameters = this.args.editingModel.parameters || [];
return {
name: this.args.editingModel.name || "",
tool_name: this.args.editingModel.tool_name || "",
description: this.args.editingModel.description || "",
summary: this.args.editingModel.summary || "",
parameters: this.args.editingModel.parameters || [],
parameters,
script: this.args.editingModel.script || "",
rag_uploads: this.args.editingModel.rag_uploads || [],
};
Expand Down Expand Up @@ -109,6 +110,10 @@ export default class AiToolEditorForm extends Component {
return data.parameters[index].type;
}

parameterIsEnum(data, index) {
return data.parameters[index].isEnum;
}

get ragUploadsDescription() {
return this.siteSettings.rag_images_enabled
? i18n("discourse_ai.rag.uploads.description_with_images")
Expand Down Expand Up @@ -229,7 +234,7 @@ export default class AiToolEditorForm extends Component {
</row.Col>

<row.Col @size={{4}}>
<collection.Field @name="enum" @title="Enum" as |field|>
<collection.Field @name="isEnum" @title="Enum" as |field|>
<field.Checkbox />
</collection.Field>
</row.Col>
Expand All @@ -243,6 +248,9 @@ export default class AiToolEditorForm extends Component {
/>
</row.Col>
</form.Row>
{{#if (this.parameterIsEnum data index)}}
I am an enum
{{/if}}
</div>
</form.Collection>

Expand All @@ -252,7 +260,9 @@ export default class AiToolEditorForm extends Component {
@action={{fn
form.addItemToCollection
"parameters"
(hash name="" type="string" description="" required=false enum=false)
(hash
name="" type="string" description="" required=false isEnum=false
)
}}
/>

Expand Down Expand Up @@ -299,18 +309,20 @@ export default class AiToolEditorForm extends Component {
class="ai-tool-editor__test-button"
/>

{{/unless}}

<form.Submit
@label="discourse_ai.tools.save"
class="ai-tool-editor__save"
/>
{{#unless @isNew}}
<form.Button
@label="discourse_ai.tools.delete"
@icon="trash-can"
@action={{this.delete}}
class="btn-danger ai-tool-editor__delete"
/>
{{/unless}}

<form.Submit
@label="discourse_ai.tools.save"
class="ai-tool-editor__save"
/>
</form.Actions>
</Form>
</template>
Expand Down
Loading