Skip to content
This repository was archived by the owner on Jul 22, 2025. It is now read-only.

FIX: Search discoveries improvements #1228

Merged
merged 7 commits into from
Mar 31, 2025
Merged

FIX: Search discoveries improvements #1228

merged 7 commits into from
Mar 31, 2025

Conversation

@keegangeorge
Copy link
Member

@keegangeorge keegangeorge commented Mar 27, 2025 •
edited
Loading

This update makes a few improvements to search discoveries:

  • in search menu panel: search discoveries should still be triggered when no regular results are present
  • in full page search: search discoveries should still be triggered when no regular results are present
  • flakiness in search discoveries sometimes not working properly.

keegangeorge and others added 4 commits March 28, 2025 11:28
@keegangeorge
DEV: Discovery improvements
17e0eb1 
- [X] Discovery results clear when query is cleared
- [X] Fixes to titles showing/hiding based on results
- [X] Loading discoveries in service
@keegangeorge
WIP: Fix medium grid layout
cb24729
@keegangeorge
lint
e9a2995
@awesomerobot
style adjustment
bc0946a
@keegangeorge keegangeorge marked this pull request as ready for review March 31, 2025 15:08
@keegangeorge keegangeorge merged commit f3e78f0 into main Mar 31, 2025
6 checks passed
@keegangeorge keegangeorge deleted the fix-discovery branch March 31, 2025 15:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@xfalcox xfalcox xfalcox approved these changes

@romanrizzi romanrizzi romanrizzi approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@keegangeorge @xfalcox @romanrizzi @awesomerobot