This repository was archived by the owner on Jul 22, 2025. It is now read-only.
FIX: invalid context construction for responders #1257
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previous to this fix we assumed the name field contained usernames when in fact it was stored in the id field. This fixes the context contruction and also adds some basic user information to the context to assist responders in understanding the cast of chars
nattsw
reviewed
Apr 11, 2025
| type: :user, | ||
| content: mapped_message, | ||
| name: m.user.username, | ||
| id: m.user.username, |
Contributor
There was a problem hiding this comment.
I believe the push method still takes in both name and id parameters in the method signature. Do we need to keep them both?
nattsw
approved these changes
Apr 11, 2025
Contributor
nattsw
left a comment
nattsw
left a comment
There was a problem hiding this comment.
Approving first, though I think def topic_array is getting quite messy and doing many things
Member
Author
|
Agree, will improve the story around this code next, but I want to get the urgent fix in first. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous to this fix we assumed the name field contained usernames
when in fact it was stored in the id field.
This fixes the context contruction and also adds some basic user
information to the context to assist responders in understanding
the cast of chars