This repository was archived by the owner on Jul 22, 2025. It is now read-only.
DEV: Add test to cover proofreading in rich editor #1259
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This core PR must be merged for this to work discourse/discourse#32280 We want to make sure we don't have regressions with this functionality in the rich editor, which uses contendeditable and other APIs than the old composer.
lis2
approved these changes
Apr 15, 2025
martin-brennan
added a commit
that referenced
this pull request
Apr 15, 2025
This reverts commit e81108a.
martin-brennan
added a commit
that referenced
this pull request
Apr 15, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This core PR must be merged for this to work
discourse/discourse#32280
We want to make sure we don't have regressions with this
functionality in the rich editor, which uses contendeditable
and other APIs than the old composer.