This repository was archived by the owner on Jul 22, 2025. It is now read-only.
FEATURE: improve context management #1260
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
SamSaffron
commented
Apr 14, 2025
SamSaffron
commented
- Add age of post to topic context (1 month ago, 1 year ago, etc)
- Refactor code for simplicity
- Fix handling of post context in DMs which was not using new handling of uploads
1. Add age of post to topic context (1 month ago, 1 year ago, etc) 2. Refactor code for simplicity 3. Fix handling of post context in DMs which was not using new handling of uploads
nattsw
reviewed
Apr 14, 2025
| prepend_chat_post_context(result) if style == :chat_with_context | ||
|
|
||
| if limit | ||
| result[0..limit] |
Contributor
There was a problem hiding this comment.
This is probably a loose limit, but 0...5 gives u 6 items.
Member
Author
There was a problem hiding this comment.
Good catch will fix in a follow up
nattsw
reviewed
Apr 14, 2025
| "#{user.username} (#{user.name}): #{info.compact.join(", ")}" | ||
| end | ||
|
|
||
| def format_timestamp(timestamp) |
Contributor
There was a problem hiding this comment.
Wow this totally looks like def format_user_info(user) 😅
nattsw
approved these changes
Apr 14, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.