DEV: Group PMs by date

[janzenisaac]

Preview

scroll.with.date.mov

Details

• Group pms by last_posted_at. In this first iteration we are group by 7 days, 30 days, then by month beyond that.
• I inject a sidebar section link with the relative (last_posted_at) date and then update a tracked value to ensure we don't do it again. Then for each month beyond the first 30days, I add a value to the loadedMonthLabels set and we reference that (plus the year) to see if we need to load a new month label.
• I took the creative liberty to remove the Conversations section label - this had no purpose
• I hid the collapse all sidebar sections carrot. This had no purpose.
• Swap BasicTopicSerializer to ListableTopicSerializer to get access to last_posted_at

[keegangeorge]

Looks good, just one small suggested change

[keegangeorge]

If all we need is last_posted_at should we instead extend BasicTopicSerializer and do something like:

class BotConversationTopicSerializer < BasicTopicSerializer
  attributes :last_posted_at
end

since ListableTopicSerializer looks like it's adding a wealth of attributes we don't really need, so doing this might keep it lightweight and avoid unnecessary db calls.

[janzenisaac]

We could... this is so light weight (overall) and we have to carry the extra extension. I think the play is to stick with Listable vs extending. Are you okay to merge as is?

[keegangeorge]

Yeah that makes sense, you're right, it's still pretty lightweight and is probably better than carrying the extra extension. ✅ Good to merge