This repository was archived by the owner on Jul 22, 2025. It is now read-only.
FEATURE: enforce jpg/png for all images #1309
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This ensures webp / gif are converted to png prior to sending to LLMs given webp and gif are not evenly supported. png/jpg is universally supported and are the only supported format. longer term we need to add support for audio/video/pdf which is supported by some models.
jjaffeux
approved these changes
May 5, 2025
| @@ -0,0 +1,13 @@ | |||
| # frozen_string_literal: true | |||
Contributor
There was a problem hiding this comment.
we should also have webp and jpeg
| desired_extension = "jpeg" if upload.extension == "jpg" | ||
|
|
||
| # this keeps it very simple format wise given everyone supports png and jpg | ||
| next if !%w[jpeg png].include?(desired_extension) |
Contributor
There was a problem hiding this comment.
should we log domething here?
Member
Author
There was a problem hiding this comment.
long term maybe, for now I think skipping obscure image formats is ok
ZogStriP
approved these changes
May 5, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures webp / gif are converted to png prior to sending
to LLMs given webp and gif are not evenly supported.
png/jpg is universally supported and are the only supported format.
longer term we need to add support for audio/video/pdf which is supported by some models.