This repository was archived by the owner on Jul 22, 2025. It is now read-only.
DEV: rewrites artifact spec with capybara waiters #1347
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generally speaking we never want to do:
```
expect(element.text).to eq("foo")
```
As these are rspec matchers and do not add further Capybara-style waiting specifically for the text content to become present.
jjaffeux
commented
May 19, 2025
| iframe_selector = "#{artifact_element_selector} iframe" | ||
| artifact_element = find(artifact_element_selector) | ||
|
|
||
| expect(page).to have_css(iframe_selector) |
Contributor
Author
There was a problem hiding this comment.
We are doing a find at tnetx step so I don't think that's necessary, we will fail on the find if it doesn’t exist
jjaffeux
commented
May 19, 2025
| expect(iframe_element["data-custom-message"]).to eq("hello-from-post") | ||
| expect(iframe_element["data-post-author-id"]).to eq(author.id.to_s) | ||
| expect(artifact_element).to have_css("iframe[data-custom-message='hello-from-post']") | ||
| expect(artifact_element).to have_css("iframe[data-post-author-id='#{author.id}']") |
Contributor
Author
There was a problem hiding this comment.
You can't check data attributes on the element itself in capybara, so the best way is to do this.
jjaffeux
commented
May 19, 2025
Comment on lines
+62
to
+64
| expect(page).to have_selector(data_selector, text: /.+/) | ||
| expect(page).to have_no_selector(data_selector, text: "Waiting for data...") | ||
| expect(page).to have_no_selector(data_selector, text: "Error:") |
Contributor
Author
There was a problem hiding this comment.
We don't want to use rspec matcher on dom elements, they are not waiting correctly
SamSaffron
approved these changes
May 19, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generally speaking we never want to do:
As these are rspec matchers and do not add further Capybara-style waiting specifically for the text content to become present.