This repository was archived by the owner on Jul 22, 2025. It is now read-only.
FEATURE: simplify streaming implementation - rush last update #1380
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previous to this change we would simply "flash" the final update on the screen, this amends it so we quickly update the UI in about 1 second in the end with all the final update. This makes the UI feel more interactive to end users.
- Remove unnecessary comments - Add doc style comments for all methods - Organize methods (private at bottom) - Update some variable names
keegangeorge
approved these changes
May 29, 2025
Member
keegangeorge
left a comment
keegangeorge
left a comment
There was a problem hiding this comment.
Awesome! Looks great, thanks Sam :)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous to this change we would simply "flash" the final update
on the screen, this amends it so we quickly update the UI in about
1 second in the end with all the final update.
This makes the UI feel more interactive to end users.