Skip to content
This repository was archived by the owner on Jul 22, 2025. It is now read-only.

FIX: enum handling needs to be done on save as well #1386

Merged
merged 1 commit into from
May 30, 2025
Merged

FIX: enum handling needs to be done on save as well #1386

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 14 additions & 3 deletions assets/javascripts/discourse/components/ai-tool-editor-form.gjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,8 +34,8 @@ export default class AiToolEditorForm extends Component {
const mappedParameter = {
...parameter,
};
parameter.isEnum = parameter.enum && parameter.enum.length > 0;
if (!parameter.isEnum) {
mappedParameter.isEnum = parameter.enum && parameter.enum.length > 0;
if (!mappedParameter.isEnum) {
delete mappedParameter.enum;
}
return mappedParameter;
Expand Down Expand Up @@ -68,8 +68,19 @@ export default class AiToolEditorForm extends Component {
async save(data) {
this.isSaving = true;

// we injected a isEnum thing, we need to clean it up
const copiedData = JSON.parse(JSON.stringify(data));
if (copiedData.parameters) {
copiedData.parameters.forEach((parameter) => {
if (!parameter.isEnum) {
delete parameter.enum;
}
delete parameter.isEnum;
});
}

try {
await this.args.model.save(data);
await this.args.model.save(copiedData);

this.toasts.success({
data: { message: i18n("discourse_ai.tools.saved") },
Expand Down
Loading