This repository was archived by the owner on Jul 22, 2025. It is now read-only.
DEV: improve tool infra, improve forum researcher prompts, improve logging #1391
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(useful for when we are polling)
SamSaffron
changed the title
nattsw
reviewed
Jun 2, 2025
|
|
||
| results = [] | ||
|
|
||
| formatter.each_chunk { |chunk| results << run_inference(chunk[:text], goals, post, &blk) } |
Contributor
There was a problem hiding this comment.
Should you also do a break if context.cancel_manager&.cancelled? here in each_chunk?
Member
Author
There was a problem hiding this comment.
I think it breaks early enough in run inf not to matter.
nattsw
reviewed
Jun 2, 2025
|
|
||
| @http_requests_made = 0 | ||
| @sleep_calls_made = 0 | ||
| @http_requests_made = 0 |
nattsw
reviewed
Jun 2, 2025
| bot = DiscourseAi::Personas::Bot.as(bot_user, persona: persona.new) | ||
|
|
||
| DiscourseAi::AiBot::Playground.new(bot).reply_to(post) | ||
| DiscourseAi::AiBot::Playground.new(bot).reply_to(post, feature_name: "bot") |
Contributor
There was a problem hiding this comment.
Would it make sense to pass this from the job caller?
Member
Author
There was a problem hiding this comment.
hmmm maybe ... this job though is dedicated to bot.
nattsw
approved these changes
Jun 2, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.