Skip to content
This repository was archived by the owner on Jul 22, 2025. It is now read-only.

FIX: Proper default LLM detection for inferred concepts #1392

Merged
merged 2 commits into from
Jun 2, 2025
Merged

FIX: Proper default LLM detection for inferred concepts #1392

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8046a6f
FIX: Proper default LLM detection for inferred concepts
xfalcox Jun 2, 2025
d4534ea
fix tests
xfalcox Jun 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/inferred_concepts/finder.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ def identify_concepts(content)
.find { |p| p.id == SiteSetting.inferred_concepts_generate_persona.to_i }
.new

llm = LlmModel.find(persona.default_llm_id)
llm = LlmModel.find(persona.class.default_llm_id)
context =
DiscourseAi::Personas::BotContext.new(
messages: [{ type: :user, content: content }],
Expand Down Expand Up @@ -154,7 +154,7 @@ def deduplicate_concepts(concept_names)
.find { |p| p.id == SiteSetting.inferred_concepts_deduplicate_persona.to_i }
.new

llm = LlmModel.find(persona.default_llm_id)
llm = LlmModel.find(persona.class.default_llm_id)

# Create the input for the deduplicator
input = { type: :user, content: concept_names.join(", ") }
Expand Down
28 changes: 20 additions & 8 deletions spec/lib/inferred_concepts/finder_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,9 +31,12 @@
bot_double = instance_double("DiscourseAi::Personas::Bot")

allow(AiPersona).to receive(:all_personas).and_return([persona_class_double])
allow(persona_class_double).to receive(:id).and_return(SiteSetting.inferred_concepts_generate_persona.to_i)
allow(persona_class_double).to receive(:id).and_return(
SiteSetting.inferred_concepts_generate_persona.to_i,
)
allow(persona_class_double).to receive(:new).and_return(persona_instance_double)
allow(persona_instance_double).to receive(:default_llm_id).and_return(llm_model.id)
allow(persona_instance_double).to receive(:class).and_return(persona_class_double)
allow(persona_class_double).to receive(:default_llm_id).and_return(llm_model.id)
allow(LlmModel).to receive(:find).with(llm_model.id).and_return(llm_model)
allow(DiscourseAi::Personas::Bot).to receive(:as).and_return(bot_double)
allow(bot_double).to receive(:reply).and_yield(
Expand All @@ -57,9 +60,12 @@
bot_double = instance_double("DiscourseAi::Personas::Bot")

allow(AiPersona).to receive(:all_personas).and_return([persona_class_double])
allow(persona_class_double).to receive(:id).and_return(SiteSetting.inferred_concepts_generate_persona.to_i)
allow(persona_class_double).to receive(:id).and_return(
SiteSetting.inferred_concepts_generate_persona.to_i,
)
allow(persona_class_double).to receive(:new).and_return(persona_instance_double)
allow(persona_instance_double).to receive(:default_llm_id).and_return(llm_model.id)
allow(persona_instance_double).to receive(:class).and_return(persona_class_double)
allow(persona_class_double).to receive(:default_llm_id).and_return(llm_model.id)
allow(LlmModel).to receive(:find).with(llm_model.id).and_return(llm_model)
allow(DiscourseAi::Personas::Bot).to receive(:as).and_return(bot_double)
allow(bot_double).to receive(:reply).and_yield(nil, nil, :text)
Expand Down Expand Up @@ -229,9 +235,12 @@
bot_double = instance_double("DiscourseAi::Personas::Bot")

allow(AiPersona).to receive(:all_personas).and_return([persona_class_double])
allow(persona_class_double).to receive(:id).and_return(SiteSetting.inferred_concepts_deduplicate_persona.to_i)
allow(persona_class_double).to receive(:id).and_return(
SiteSetting.inferred_concepts_deduplicate_persona.to_i,
)
allow(persona_class_double).to receive(:new).and_return(persona_instance_double)
allow(persona_instance_double).to receive(:default_llm_id).and_return(llm_model.id)
allow(persona_instance_double).to receive(:class).and_return(persona_class_double)
allow(persona_class_double).to receive(:default_llm_id).and_return(llm_model.id)
allow(LlmModel).to receive(:find).with(llm_model.id).and_return(llm_model)
allow(DiscourseAi::Personas::Bot).to receive(:as).and_return(bot_double)
allow(bot_double).to receive(:reply).and_yield(
Expand All @@ -255,9 +264,12 @@
bot_double = instance_double("DiscourseAi::Personas::Bot")

allow(AiPersona).to receive(:all_personas).and_return([persona_class_double])
allow(persona_class_double).to receive(:id).and_return(SiteSetting.inferred_concepts_deduplicate_persona.to_i)
allow(persona_class_double).to receive(:id).and_return(
SiteSetting.inferred_concepts_deduplicate_persona.to_i,
)
allow(persona_class_double).to receive(:new).and_return(persona_instance_double)
allow(persona_instance_double).to receive(:default_llm_id).and_return(llm_model.id)
allow(persona_instance_double).to receive(:class).and_return(persona_class_double)
allow(persona_class_double).to receive(:default_llm_id).and_return(llm_model.id)
allow(LlmModel).to receive(:find).with(llm_model.id).and_return(llm_model)
allow(DiscourseAi::Personas::Bot).to receive(:as).and_return(bot_double)
allow(bot_double).to receive(:reply).and_yield(nil, nil, :text)
Expand Down
Loading