This repository was archived by the owner on Jul 22, 2025. It is now read-only.
FIX: always render "today" on top of conversation sidebar #1400
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xfalcox
approved these changes
Jun 3, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
follow-up to fa51e9d
Because sidebar sections are only registered once, a new "today" section wouldn’t appear until the sidebar re-rendered — which doesn’t happen immediately when posting a new bot PM.
This change always registers a "today" section up front, and uses CSS to hide it until it's populated with a message.
Before (if you don't have a "today" section yet, you don't get one until refresh)
After ("today" section appears with new messages)