This repository was archived by the owner on Jul 22, 2025. It is now read-only.
DEV: makes ai menu helper a standalone menu #1434
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current menu was rendering inside the post text toolbar (on desktop). This is not ideal as the post text toolbar rendering is conditioned on the presence of text selection, when you click a button on the toolbar, by design of the web browsers you will lose your text selection, making all of this super tricky. This commit makes desktop and mobile behave in the same way by rendering their own menu and capturing the quote state when we render the post text selection toolbar, this allows us to reason a much simpler way about the AI helper. This commit also removes what appears to be an unused file and corrects which was seemingly copy/paste mistakes.
jjaffeux
commented
Jun 15, 2025
jjaffeux
commented
Jun 15, 2025
jjaffeux
commented
Jun 15, 2025
assets/javascripts/discourse/connectors/post-text-buttons/ai-post-helper-trigger.gjs
Show resolved
Hide resolved
jjaffeux
commented
Jun 15, 2025
assets/javascripts/discourse/connectors/post-text-buttons/ai-post-helper-trigger.gjs
Show resolved
Hide resolved
There was a problem hiding this comment.
Overall the adjustments look good, but we need to fix those two references to this.args.data.selectedText.
Also, previously the menu inherited a behavior from post-text-selection-menu that's gone now. Before, when you have the menu open and scroll, the menu stays in position near the text you selected, but now the menu scrolls as with you as you move. Can we add back that behavior?
jjaffeux
commented
Jun 17, 2025
keegangeorge
approved these changes
Jun 18, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current menu was rendering inside the post text toolbar (on desktop). This is not ideal as the post text toolbar rendering is conditioned on the presence of text selection, when you click a button on the toolbar, by design of the web browsers you will lose your text selection, making all of this super tricky.
This commit makes desktop and mobile behave in the same way by rendering their own menu and capturing the quote state when we render the post text selection toolbar, this allows us to reason a much simpler way about the AI helper.
This commit also removes what appears to be an unused file and corrects which was seemingly copy/paste mistakes.