This repository was archived by the owner on Jul 22, 2025. It is now read-only.
FIX: never block spam scanning user #1437
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously staff and bots would get scanned if TL was low Additionally if somehow spam scanner user was blocked (deactivated, silenced, banned) it would stop the feature from working This adds an override that ensures unconditionally the user is setup correctly prior to scanning
lis2
approved these changes
Jun 17, 2025
| user.update!(silenced_till: nil) if user.silenced? | ||
| user.update!(trust_level: TrustLevel[4]) if user.trust_level != TrustLevel[4] | ||
| user.update!(suspended_till: nil, suspended_at: nil) if user.suspended? | ||
| user.update!(active: true) if !user.active? |
There was a problem hiding this comment.
Instead of having this code, what do you think of a migration to unsilence, activate and unsuspend all bots?
There was a problem hiding this comment.
I worry that then users can still do this to themselves on the admin page for the bot without understanding the impact 😢 maybe we should ban particular actions on bots from the admin interface?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously staff and bots would get scanned if TL was low
Additionally if somehow spam scanner user was blocked
(deactivated, silenced, banned) it would stop the feature from working
This adds an override that ensures unconditionally the user is setup correctly prior to scanning