Skip to content
This repository was archived by the owner on Jul 22, 2025. It is now read-only.

FIX: Cleanup properties on closing DiffModal #1442

Merged
merged 3 commits into from
Jun 17, 2025
Merged

FIX: Cleanup properties on closing DiffModal #1442

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
aab759d
FIX: Cleanup properties on closing `DiffModal`
keegangeorge Jun 17, 2025
3377dbd
DEV: consolidate in method and always reset before suggesting
keegangeorge Jun 17, 2025
e177762
DEV: semantics...
keegangeorge Jun 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 17 additions & 4 deletions assets/javascripts/discourse/components/modal/diff-modal.gjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,8 +114,7 @@ export default class ModalDiffModal extends Component {

@action
async suggestChanges() {
this.smoothStreamer.resetStreaming();
this.diffStreamer.reset();
this.#resetState();

try {
this.loading = true;
Expand Down Expand Up @@ -159,11 +158,25 @@ export default class ModalDiffModal extends Component {
}
}

@action
cleanupAndClose() {
this.#resetState();
this.loading = false;
this.args.closeModal();
}

#resetState() {
this.suggestion = "";
this.finalResult = "";
this.smoothStreamer.resetStreaming();
this.diffStreamer.reset();
}

<template>
<DModal
class="composer-ai-helper-modal"
@title={{i18n "discourse_ai.ai_helper.context_menu.changes"}}
@closeModal={{@closeModal}}
@closeModal={{this.cleanupAndClose}}
>
<:body>
<div
Expand Down Expand Up @@ -218,7 +231,7 @@ export default class ModalDiffModal extends Component {
</DButton>
<DButton
class="btn-flat discard"
@action={{@closeModal}}
@action={{this.cleanupAndClose}}
@label="discourse_ai.ai_helper.context_menu.discard"
/>
<DButton
Expand Down
Loading