This repository was archived by the owner on Jul 22, 2025. It is now read-only.
DEV: Split content based on llmmodel's max_output_tokens #1456
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martin-brennan
previously approved these changes
Jun 23, 2025
nattsw
changed the title
nattsw
requested review from
martin-brennan
and removed request for
martin-brennan
keegangeorge
approved these changes
Jun 23, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In discourse/discourse-translator#249 we introduced splitting content (
post.raw) prior to sending to translation as we were using a sync api.Now that we're streaming thanks to #1424, we'll chunk based on the
LlmModel.max_output_tokens.