This repository was archived by the owner on Jul 22, 2025. It is now read-only.
FIX: Ignore captions and quotes when detecting locale and update prompts #1483
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nattsw
changed the title
jjaffeux
reviewed
Jul 2, 2025
Comment on lines
14
to
30
| # quotes and blockquotes | ||
| doc.css("blockquote, aside.quote").remove | ||
| # image captions | ||
| doc.css(".lightbox-wrapper").remove | ||
|
|
||
| necessary = doc.text.strip | ||
|
|
||
| # oneboxes (external content) | ||
| doc.css("aside.onebox").remove | ||
| # code blocks | ||
| doc.css("code, pre").remove | ||
| # hashtags | ||
| doc.css("a.hashtag-cooked").remove | ||
| # emoji | ||
| doc.css("img.emoji").remove | ||
| # mentions | ||
| doc.css("a.mention").remove |
There was a problem hiding this comment.
I would group stuff in constants, to have only two remove calls.
I don't think the comments are adding much: # emoji => img.emoji. But if you still think they are important you can format like this:
NECESSARY_SELECTORS = [
"aside.onebox", # oneboxes (external content)
"code, pre", # code blocks
...
]and then call: doc.css(*NECESSARY_SELECTORS).remove
There was a problem hiding this comment.
I would also add that necessary/preferred is not very clear. I don't really know why they are necessary or preferred, this is where we would need a comment IMO.
jjaffeux
approved these changes
Jul 2, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A more deterministic way of making sure the LLM detects the correct language (instead of relying on prompt to LLM to ignore it) is to take the cooked and remove unwanted elements.
In this PR
/152465/12