This repository was archived by the owner on Jul 22, 2025. It is now read-only.
FIX: correctly translate automation name #1485
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The key is persona, not name.
jjaffeux
changed the title
jjaffeux
commented
Jul 3, 2025
Comment on lines
-115
to
-125
| if (usage.type === "ai_persona") { | ||
| return i18n("discourse_ai.llms.usage.ai_persona", { | ||
| persona: usage.name, | ||
| }); | ||
| } else if (usage.type === "automation") { | ||
| return i18n("discourse_ai.llms.usage.automation", { | ||
| name: usage.name, | ||
| }); | ||
| } else { | ||
| return i18n("discourse_ai.llms.usage." + usage.type); | ||
| } |
There was a problem hiding this comment.
I don't think we needed all this complexity here, I get that we think name is more accurate than persona for automation, but this forces us to always have a special case for it (and created this bug, as we forgot the special case at another place). Maybe we could also think of a more generic name, like: identifier.
|
well it is certainly better than showing something totally broken, going to merge, thanks @jjaffeux |
SamSaffron
approved these changes
Jul 4, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The key is
persona, notname.Before:
After the fix:
