Skip to content
This repository was archived by the owner on Jul 22, 2025. It is now read-only.

FIX: Fix embeddings to use the old OpenAI tokenizer #1506

Merged
merged 1 commit into from
Jul 15, 2025
Merged

FIX: Fix embeddings to use the old OpenAI tokenizer #1506

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions app/models/embedding_definition.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ def presets
dimensions: 2000,
max_sequence_length: 8191,
pg_function: "<=>",
tokenizer_class: "DiscourseAi::Tokenizer::OpenAiTokenizer",
tokenizer_class: "DiscourseAi::Tokenizer::OpenAiCl100kTokenizer",
url: "https://api.openai.com/v1/embeddings",
provider: OPEN_AI,
matryoshka_dimensions: true,
Expand All @@ -98,7 +98,7 @@ def presets
dimensions: 1536,
max_sequence_length: 8191,
pg_function: "<=>",
tokenizer_class: "DiscourseAi::Tokenizer::OpenAiTokenizer",
tokenizer_class: "DiscourseAi::Tokenizer::OpenAiCl100kTokenizer",
url: "https://api.openai.com/v1/embeddings",
provider: OPEN_AI,
matryoshka_dimensions: true,
Expand All @@ -112,7 +112,7 @@ def presets
dimensions: 1536,
max_sequence_length: 8191,
pg_function: "<=>",
tokenizer_class: "DiscourseAi::Tokenizer::OpenAiTokenizer",
tokenizer_class: "DiscourseAi::Tokenizer::OpenAiCl100kTokenizer",
url: "https://api.openai.com/v1/embeddings",
provider: OPEN_AI,
provider_params: {
Expand Down
14 changes: 14 additions & 0 deletions db/migrate/20250715165701_update_open_ai_embeddings_tokenizer.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
# frozen_string_literal: true
class UpdateOpenAiEmbeddingsTokenizer < ActiveRecord::Migration[7.2]
def up
execute <<~SQL
UPDATE embedding_definitions
SET tokenizer_class = 'DiscourseAi::Tokenizer::OpenAiCl100kTokenizer'
WHERE url LIKE '%https://api.openai.com/%' AND tokenizer_class <> 'DiscourseAi::Tokenizer::OpenAiCl100kTokenizer'
SQL
end

def down
raise ActiveRecord::IrreversibleMigration
end
end
2 changes: 1 addition & 1 deletion spec/system/embeddings/ai_embedding_definition_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@
form.field("provider").select(EmbeddingDefinition::OPEN_AI)
form.field("url").fill_in("https://api.openai.com/v1/embeddings")
form.field("api_key").fill_in(api_key)
form.field("tokenizer_class").select("DiscourseAi::Tokenizer::OpenAiTokenizer")
form.field("tokenizer_class").select("DiscourseAi::Tokenizer::OpenAiCl100kTokenizer")

embed_prefix = "On creation:"
search_prefix = "On search:"
Expand Down
Loading