Skip to content
This repository was archived by the owner on Jul 22, 2025. It is now read-only.

Conversation

@devhaozi
Copy link
Contributor

@devhaozi devhaozi commented Apr 27, 2024

According to the documentation of huggingface: By default the server responds to every request. With an api key set, the requests must have the Authorization header set with the api key as Bearer token., the use of API_KEY in the plugin is incorrect, and should use Bearer Token.

Source doc url: https://github.com/huggingface/text-embeddings-inference?tab=readme-ov-file#docker

@xfalcox
Copy link
Member

xfalcox commented Apr 30, 2024

Our implementation predates TEI support for API keys by a couple months, so we relied on a reverse proxy doing API Key header verification that uses this signature, meaning we can't simply merge this.

@devhaozi
Copy link
Contributor Author

Our implementation predates TEI support for API keys by a couple months, so we relied on a reverse proxy doing API Key header verification that uses this signature, meaning we can't simply merge this.

If so, what do you think about adding both the X-API-KEY and Authorization headers?

@devhaozi
Copy link
Contributor Author

@xfalcox fixed, PTAL.

@SamSaffron
Copy link
Member

@xfalcox what should we do here?

@xfalcox
Copy link
Member

xfalcox commented Oct 16, 2024

Hey @devhaozi I have rebased it at #839 and tests pass. Can you rebase it properly, or can I merge #839 ?

@devhaozi
Copy link
Contributor Author

Hey @devhaozi I have rebased it at #839 and tests pass. Can you rebase it properly, or can I merge #839 ?

Yes, you can.

@devhaozi devhaozi closed this Oct 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants