-
Notifications
You must be signed in to change notification settings - Fork 40
FEATURE: RAG search within tools #802
Conversation
This implements the back end for RAG search
a7da343 to
5c4fb04
Compare
| <a | ||
| href="#" | ||
| class="rag-options__indexing-options" | ||
| {{on "click" this.toggleIndexingOptions}} | ||
| >{{this.indexingOptionsText}}</a> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we use a button here? It's a lot of code just because we try to use an anchor for something which is not an anchor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
probably, will leave this to @awesomerobot to address in a followup, he probably wants to rethink some of the design here.
| # name :string not null | ||
| # description :string not null | ||
| # summary :string not null | ||
| # parameters :jsonb not null | ||
| # script :text not null |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we limit the size of these fields?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah probably but a bit unrelated to this commit, it was there from before
| export default class PersonaRagUploader extends Component.extend( | ||
| UppyUploadMixin | ||
| ) { | ||
| export default class RagUploader extends Component.extend(UppyUploadMixin) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@davidtaylorhq FYI as you are working on this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have enough knowledge of discourse-ai to have a very strong opinion, but I saw nothing stopping to merge this.
This allows custom tools access to uploads and sophisticated searches using embedding.
It introduces:
index.searchfunction within a custom tool.Custom tools now may search through uploaded files
This means that RAG implementers now may preload tools with knowledge and have high fidelity over
the search.
The search function support
Also