This repository was archived by the owner on Jul 22, 2025. It is now read-only.
FEATURE: improve visibility of AI usage in LLM page #845
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also, properly set LLM when swapping persona and ensure PM recipients are properly updated
Member
Author
|
will sort out system test tomorrow. |
romanrizzi
approved these changes
Oct 21, 2024
lib/configuration/llm_validator.rb
Outdated
| module DiscourseAi | ||
| module Configuration | ||
| class LlmValidator | ||
| def self.global_usage |
Member
There was a problem hiding this comment.
Maybe move this over to LlmEnumerator?
| if (scope && scope[:llm_usage]) | ||
| scope[:llm_usage] | ||
| else | ||
| DiscourseAi::Configuration::LlmValidator.global_usage |
Member
There was a problem hiding this comment.
Might be better to use {} here? Users of this serializer should provide the usage in the scope after all.
Member
Author
There was a problem hiding this comment.
maybe but then we would need amend all the usages in the controller which is a bigger change.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, properly set LLM when swapping persona and ensure PM
recipients are properly updated
New UI is:
And:
This means you can operate with 100% tethered personas and the LLM selector is not required.
Cleans up UI so it is clearer