This repository was archived by the owner on Jul 22, 2025. It is now read-only.
FEATURE: improve tool support #904
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This work in progress PR amends llm completion so it returns objects for tools vs XML fragments This will empower future features such as parameter streaming XML was error prone, object implementation is more robust Still very much in progress, a lot of code needs to change Partially implemented on Anthropic at the moment.
Member
Author
|
Notable compromise: .generate will return either an Array (for tool call + completion) or a single element for a single element array. This does place some responsibility on caller who may get differently shaped data. We could always return an array but it will make it more complex to consume for cases where you are not using tools. |
romanrizzi
approved these changes
Nov 11, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This re-implements tool support in
DiscourseAi::Completions::Llm#generatePreviously tool support was always returned via XML and it would be the responsibility of the caller to parse XML
New implementation has the endpoints return ToolCall objects.
Additionally this simplifies the Llm endpoint interface and gives it more clarity. Llms must implement
decode, decode_chunk (for streaming)
It is the implementers responsibility to figure out how to decode chunks, base no longer implements. To make this easy we ship a flexible json decoder which is easy to wire up.
Also (new)