This repository was archived by the owner on Jul 22, 2025. It is now read-only.
FIX: cancel functionality regressed #938
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The cancel messaging was not floating correctly to the HTTP call
martin-brennan
approved these changes
Nov 21, 2024
Contributor
martin-brennan
left a comment
martin-brennan
left a comment
There was a problem hiding this comment.
Don't really understand it but approving since it's a big bug 👍
Member
Author
|
I am trying to write a test, if I can one done with it now I will merge ... it is just very hard to test. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The cancel messaging was not floating correctly to the HTTP call