DEV: Update for glimmer topic list #66
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidtaylorhq
commented
Jan 6, 2025
| () => true | ||
| ); | ||
|
|
||
| if (!transformerExists) { |
Member
Author
There was a problem hiding this comment.
Transformer was only introduced a couple of days ago, and there hasn't been a version bump since, so the d-compat entry won't work for every case. Adding some conditional logic which falls-back to the modifyClass instead.
withSilencedDeprecations is mostly included for grep-ability when we come to clean up themes/plugins after the topic-list conversion is complete.
janzenisaac
approved these changes
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.