Skip to content

UX: normalize locale #86

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 13, 2025
Merged

UX: normalize locale #86

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ed76ae0
UX: normalize locale
awesomerobot May 13, 2025
8d3125f
cover more cases
awesomerobot May 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion javascripts/discourse/components/custom-header-links.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,9 @@
import Component from "@glimmer/component";
import { dasherize } from "@ember/string";

function normalizeLocale(locale) {
return locale?.trim().toLowerCase().replace(/[-_]/g, "_");
}
export default class CustomHeaderLinks extends Component {
get shouldShow() {
return settings.custom_header_links?.length > 0;
Expand All @@ -16,7 +19,9 @@ export default class CustomHeaderLinks extends Component {
const locale = link.locale;
const device = link.view;

if (!linkText || (locale && document.documentElement.lang !== locale)) {
const currentLocale = normalizeLocale(document.documentElement.lang);

if (!linkText || (locale && normalizeLocale(locale) !== currentLocale)) {
return result;
}

Expand Down