Skip to content

Conversation

@nullchristo
Copy link
Contributor

@nullchristo nullchristo commented Sep 23, 2025

Adds a new theme component setting called max_number_of_topics, defaulting to 0.

Unless this is set to a number greater than the number_of_topics setting, behavior should be unchanged.

If it's set to a higher number AND there are enough featured topics to have more than one page, page arrows will appear allowing the user to cycle through pages of featured topics with each page having number_of_topics topics displayed. The left/right arrow buttons should only display if there are additional pages in that direction.

Tries to play nicely with the show_all_always setting and handles small screen sizes in the same way (lowering the number of displayed topics as the screen shrinks, but still allowing all topics included by max_number_of_topics to be paged through).

Kooha-2025-09-23-16-06-20.webm

Requested in this meta topic: https://meta.discourse.org/t/331599

@pento
Copy link
Member

pento commented Sep 24, 2025

A quick note while looking at this: does pnpm-lock.yml actually need updating? It appears to only be formatting changes to the file.

@nullchristo
Copy link
Contributor Author

A quick note while looking at this: does pnpm-lock.yml actually need updating? It appears to only be formatting changes to the file.

Yeah, not necessary just caught by the linter I think. Seems harmless to include but I can remove it.

Copy link
Contributor

@pmusaraj pmusaraj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@nullchristo nullchristo merged commit b66ce55 into main Sep 24, 2025
4 checks passed
@nullchristo nullchristo deleted the feature/add-pagination branch September 24, 2025 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants