DEV: Migrate settings from deprecated icon names #37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CvX
approved these changes
Dec 20, 2024
…, also rename setting to lowercase of svg_icons
tyb-talks
force-pushed
the
dev-migrate-deprecated-icon-names
branch
from
777c299 to
a422d57
Compare
CvX
approved these changes
Dec 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR migrates deprecated Font Awesome icon names saved in settings. For more detail, refer to the announcement at https://meta.discourse.org/t/-/325349.
This includes renaming the
Svg_iconssetting tosvg_icons.The migration function is intentionally copying the same type of operations in https://github.com/discourse/discourse/blob/435fbb74082e1d060f97267a62dfa29c73979127/lib/svg_sprite.rb#L519 as that's used to convert the icon names in core.