Use PNG screenshots for Discourse compatibility#64
Closed
ieduer wants to merge 1 commit intodiscourse:mainfrom
Closed
Use PNG screenshots for Discourse compatibility#64ieduer wants to merge 1 commit intodiscourse:mainfrom
ieduer wants to merge 1 commit intodiscourse:mainfrom
Conversation
Contributor
martin-brennan
left a comment
martin-brennan
left a comment
There was a problem hiding this comment.
This is a bit confusing, we actually recently added webp support:
So the theme can stay as is.
Contributor
|
@martin-brennan that was because this theme (and a few others) was missing a .discourse-compatibility entry so webp images broke for those not on the latest commit version of core. I added those entries so this can be closed now 👍 |
Contributor
|
@cvx thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates the Mint theme's screenshots to use PNG files so they comply with Discourse's current theme screenshot requirements.
Background
In
about.json, the theme previously referenced:However, Discourse only accepts jpg, jpeg, gif, or png as valid screenshot formats for themes. When installing or updating the theme via /admin/customize/themes, this results in an error like:
The theme screenshots must be in one of the following formats: .jpg, .jpeg, .gif, .png. The screenshot light.webp has an invalid format.
Changes
• Added screenshots/light.png converted from light.webp
• Added screenshots/dark.png converted from dark.webp
• Updated about.json:
Testing
• Installed/updated the theme from this branch on a Discourse instance
• Confirmed the invalid screenshot format error no longer appears
• Verified that the screenshots display correctly in the admin UI