DEV: Update tag_id usage to tag_name where a tag's name is referenced #91
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Note: test will fail until discourse/discourse#36226 is merged. |
ZogStriP
approved these changes
Dec 26, 2025
tgxworld
pushed a commit
that referenced
this pull request
Jan 19, 2026
…#91) * DEV: Update tag_id usage to tag_name where a tag's name is referenced * cannot use tagName since special keyword
tgxworld
pushed a commit
that referenced
this pull request
Jan 19, 2026
…#91) * DEV: Update tag_id usage to tag_name where a tag's name is referenced * cannot use tagName since special keyword
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
context
Related: discourse/discourse#36226
The
TagShowRouteoriginally stores the backend-returned tagtag = { id: 123, name: "tag-name" }into the frontend model as{ id: tag.name }.change made
This theme component thus uses
"router.currentRoute.attributes.tag.id", which needs to be converted to"router.currentRoute.attributes.tag.name"instead.