DEV: Add backward compatibility for tag object arrays#92
Merged
Conversation
tgxworld
force-pushed
the
fix-tag-object-compatibility
branch
from
481175f to
5f8c00f
Compare
ZogStriP
approved these changes
Jan 16, 2026
tgxworld
force-pushed
the
fix-tag-object-compatibility
branch
8 times, most recently
from
0b7bceb to
7b6fcd4
Compare
What is the problem?
Discourse core PR #36678 changes `site.top_tags` and
`site.category_top_tags` from string arrays (e.g., `["support", "bug"]`)
to object arrays (e.g., `[{id: 12, name: "support", slug: "support"}]`).
This breaks the `PopularTags` component which filters and displays tags
as strings.
What is the solution?
Normalize the tags array by mapping and extracting names using
`typeof tag === "string" ? tag : tag.name` before filtering against
excluded tags. This ensures backward compatibility with both the old
string format and the new object format.
tgxworld
force-pushed
the
fix-tag-object-compatibility
branch
from
7b6fcd4 to
e246733
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the problem?
Discourse core PR #36678 changes
site.top_tagsandsite.category_top_tagsfrom string arrays (e.g.,["support", "bug"])to object arrays (e.g.,
[{id: 12, name: "support", slug: "support"}]).This breaks the
PopularTagscomponent which filters and displays tagsas strings.
What is the solution?
Normalize the tags array by mapping and extracting names using
typeof tag === "string" ? tag : tag.namebefore filtering againstexcluded tags. This ensures backward compatibility with both the old
string format and the new object format.