Skip to content

UX: Add wrap class back #91

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 24, 2025
Merged

UX: Add wrap class back #91

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions common/common.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,10 @@
}
}

h1 {
text-align: center;
}

Comment on lines +61 to +64
Copy link
Member

@keegangeorge keegangeorge Apr 24, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this intentional?

Copy link
Contributor Author

@jordanvidrine jordanvidrine Apr 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes it is. In core this exists, with styles applied to welcome-banner__title. It has been migrated to a div due to a11y reasons. I did not want to do so here in case of breaking more things.

.btn.search-icon.has-search-button-text {
margin-left: 0.5em;
column-gap: 0.5em;
Expand Down
2 changes: 1 addition & 1 deletion javascripts/discourse/components/search-banner.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
{{did-insert this.didInsert}}
{{will-destroy this.willDestroy}}
>
<div class="custom-search-banner-wrap welcome-banner__wrap">
<div class="wrap custom-search-banner-wrap welcome-banner__wrap">
<h1>{{html-safe (theme-i18n "search_banner.headline")}}</h1>
<PluginOutlet @name="search-banner-below-headline" />
<p>{{html-safe (theme-i18n "search_banner.subhead")}}</p>
Expand Down