FIX: Ensure translated content is safe for rendering #220
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
|
nattsw
commented
Feb 25, 2025
| module DiscourseTranslator | ||
| class TranslatedContentSanitizer | ||
| def self.sanitize(content) | ||
| PrettyText.cleanup(content, {}) |
Contributor
Author
There was a problem hiding this comment.
The sanitizer only calls prettytext for now.
In general I would be moving towards creating specific classes as we may see this function expand.
nattsw
commented
Feb 25, 2025
| @@ -1,3 +1,4 @@ | |||
| < 3.5.0.beta2-dev: 5f24835801fdc7cb98e1bcf42d2ab2e49e609921 | |||
Contributor
Author
There was a problem hiding this comment.
Made a mistake in my previous compat file update...
We are on 3.5.0.beta2-dev now, and the commit before this one is 5f24835801fdc7cb98e1bcf42d2ab2e49e609921.
This PR uses PrettyText.cleanup(content, {}) which is new in core.
tyb-talks
approved these changes
Feb 26, 2025
Contributor
Author
|
ty @tyb-talks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As much as we would like to trust AI / translation API outputs, we're adding a bit of sanitisation here for simple things like script tags in case.